Bug 455757 - Review Request: pyexiv2 - Python binding to exiv2
Review Request: pyexiv2 - Python binding to exiv2
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dan Horák
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-17 12:14 EDT by Matěj Cepl
Modified: 2008-07-18 18:19 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-18 18:19:51 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dan: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Matěj Cepl 2008-07-17 12:14:40 EDT
Spec URL: http://mcepl.fedorapeople.org/rpms/pyexiv2.spec
SRPM URL: http://mcepl.fedorapeople.org/rpms/pyexiv2-0.1.2-1.fc9.src.rpm
Description:
pyexiv2 is a python binding to exiv2, the C++ library for manipulation
of EXIF and IPTC image metadata. It is a python module that allows your
python scripts to read and write metadata (EXIF, IPTC, thumbnail)
embedded in image files (JPEG, TIFF, ...).
Comment 1 Matěj Cepl 2008-07-17 12:15:02 EDT
Builds in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=722738
Comment 2 Dan Horák 2008-07-17 12:56:21 EDT
OK*	source files match upstream:
	    6ae7aa7e155117ea2356e78112ede2031fc06c8e  pyexiv2-0.1.2.tar.bz2
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
BAD	license field matches the actual license.
OK	license is open source-compatible (GPLv2+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
BAD	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
BAD	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

- use full URL to the source archive
- license tag should be GPLv2+
- package's own compile flags are used (see
http://dev.gentoo.org/~vapier/scons-blows.txt)
- debuginfo doesn't contain source files - depends on the right flags
Comment 3 Matěj Cepl 2008-07-17 19:35:34 EDT
SPEC file is in the same URL, and updated.
SRPM is http://mcepl.fedorapeople.org/rpms/pyexiv2-0.1.2-2.fc9.src.rpm

Thanks, Dan, for the help.
Comment 4 Dan Horák 2008-07-18 02:06:16 EDT
Matěj, you forgot to use the full URL for the source archive
(http://tilloy.net/dev/pyexiv2/releases/pyexiv2-0.1.2.tar.bz2). This package is
APPROVED when the Source0 tag is updated.
Comment 5 Matěj Cepl 2008-07-18 07:15:30 EDT
New Package CVS Request
=======================
Package Name: pyexiv2
Short Description: Python binding to exiv2
Owners:mcepl
Branches: F-8 F-9
InitialCC:
Cvsextras Commits:yes
Comment 6 Kevin Fenzi 2008-07-18 12:37:21 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.