Red Hat Bugzilla – Bug 455757
Review Request: pyexiv2 - Python binding to exiv2
Last modified: 2008-07-18 18:19:51 EDT
Spec URL: http://mcepl.fedorapeople.org/rpms/pyexiv2.spec
SRPM URL: http://mcepl.fedorapeople.org/rpms/pyexiv2-0.1.2-1.fc9.src.rpm
pyexiv2 is a python binding to exiv2, the C++ library for manipulation
of EXIF and IPTC image metadata. It is a python module that allows your
python scripts to read and write metadata (EXIF, IPTC, thumbnail)
embedded in image files (JPEG, TIFF, ...).
Builds in koji
OK* source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
BAD license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
BAD debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- use full URL to the source archive
- license tag should be GPLv2+
- package's own compile flags are used (see
- debuginfo doesn't contain source files - depends on the right flags
SPEC file is in the same URL, and updated.
SRPM is http://mcepl.fedorapeople.org/rpms/pyexiv2-0.1.2-2.fc9.src.rpm
Thanks, Dan, for the help.
Matěj, you forgot to use the full URL for the source archive
(http://tilloy.net/dev/pyexiv2/releases/pyexiv2-0.1.2.tar.bz2). This package is
APPROVED when the Source0 tag is updated.
New Package CVS Request
Package Name: pyexiv2
Short Description: Python binding to exiv2
Branches: F-8 F-9
build in Rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=726007