Bug 457806
| Summary: | Review Request: python-chardet - Character encoding auto-detection in Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | kushaldas@gmail.com <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade, th0br0 |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-13 18:18:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956417 | ||
|
Description
kushaldas@gmail.com
2008-08-04 18:50:43 UTC
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=758670 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f8c510a6fac300fe0ac9a0c24a76a7ba chardet-1.0.1.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Suggestions: * Add docs/* directory from source to %doc * As all source files also include License text your license should be LGPLv2+ APPROVED. (In reply to comment #1) > > Suggestions: > * Add docs/* directory from source to %doc > * As all source files also include License text your license should be > LGPLv2+ Changes made :) New Package CVS Request ======================= Package Name: python-chardet Short Description: Character encoding auto-detection in Python Owners: kushal Branches: F-9 EL-5 InitialCC: kushal Cvsextras Commits: yes cvs done. New Package CVS Request ======================= Package Name: python-chardet Short Description: Character encoding auto-detection in Python Owners: kushal Branches: F-10 InitialCC: kushal Cvsextras Commits: yes *** Bug 492612 has been marked as a duplicate of this bug. *** cvs done. |