Spec URL: http://kushal.fedorapeople.org/packages/python-chardet.spec SRPM URL: http://kushal.fedorapeople.org/packages/python-chardet-1.0.1-1.fc9.src.rpm Description: Character encoding auto-detection in Python. As smart as your browser. Open source.
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=758670 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f8c510a6fac300fe0ac9a0c24a76a7ba chardet-1.0.1.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Suggestions: * Add docs/* directory from source to %doc * As all source files also include License text your license should be LGPLv2+ APPROVED.
(In reply to comment #1) > > Suggestions: > * Add docs/* directory from source to %doc > * As all source files also include License text your license should be > LGPLv2+ Changes made :)
New Package CVS Request ======================= Package Name: python-chardet Short Description: Character encoding auto-detection in Python Owners: kushal Branches: F-9 EL-5 InitialCC: kushal Cvsextras Commits: yes
cvs done.
New Package CVS Request ======================= Package Name: python-chardet Short Description: Character encoding auto-detection in Python Owners: kushal Branches: F-10 InitialCC: kushal Cvsextras Commits: yes
*** Bug 492612 has been marked as a duplicate of this bug. ***