Bug 458213

Summary: [PATCH] Make iscsid wake up less when idle
Product: [Fedora] Fedora Reporter: Adam Jackson <ajax>
Component: iscsi-initiator-utilsAssignee: Andy Grover <agrover>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: agrover, cleech, jfeeney, rvokal
Target Milestone: ---Keywords: FutureFeature, Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-15 04:49:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 438944    
Attachments:
Description Flags
patch
none
open-iscsi-2.0-poll-less.patch none

Description Adam Jackson 2008-08-07 01:04:05 UTC 
Description of problem:

libvirt pulls in iscsi-initiator-utils for some possibly valid reason.  i-i-u enables its initscript by default for some possibly valid reason.  iscsid wakes up four times a second to poll for nonexistent actor threads, for absolutely no reason.

We should at least not wake up so much.  Attached patch does at least something close to the right thing.  I've not tested it in an iscsi configuration, because I don't have one, but it certainly doesn't wake up uselessly any more.  It's possibly racy, in that i don't know if the actor refcount needs to be done with atomic operations.
Comment 1 Adam Jackson 2008-08-07 01:11:50 UTC 
Created attachment 313656 [details]
patch
Comment 2 John Poelstra 2008-10-16 02:40:00 UTC 
This bug has been triaged
Comment 3 Adam Jackson 2010-08-26 17:56:51 UTC 
Created attachment 441292 [details]
open-iscsi-2.0-poll-less.patch

Updated the patch to account for the event loop being moved around.
Comment 4 Adam Jackson 2012-04-17 19:33:27 UTC 
Still valid...
Comment 5 Mike Christie 2012-05-04 18:21:12 UTC 
*** Bug 819065 has been marked as a duplicate of this bug. ***
Comment 6 Adam Jackson 2013-02-03 21:26:09 UTC 
I filed this bug about... 54 months ago, if my math is right.  Today I checked in my F19 virtual machine, and I _still_ have an iscsid waking up five times a second to do absolutely nothing.
Comment 7 Andy Grover 2014-10-03 16:16:24 UTC 
That patchset was rejected upstream, there's some potential for zombie processes, apparently. I'm looking at this now.
Comment 8 Andy Grover 2015-01-16 23:47:50 UTC 
Progress! Patches accepted upstream.