Bug 458617
Summary: | Review Request: xorg-x11-drv-synaptics - Xorg X11 synaptics input driver | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Hutterer <peter.hutterer> |
Component: | Package Review | Assignee: | Dan Horák <dan> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, nobody, notting |
Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-12 07:38:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peter Hutterer
2008-08-11 00:53:01 UTC
*** Bug 226446 has been marked as a duplicate of this bug. *** formal review is here, see the notes below OK source files match upstream: 41eaa1c77af11166ff5ec4abc013076f545bc676 xf86-input-synaptics-0.15.0.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package. OK latest version is being packaged. OK* BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK* package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - when libtool is used as BR: then autoconf and automake are redundant - parallel make is not used - see https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - you should include README as %doc Thanks! Updated spec file and srpm available at the URLs above. (In reply to comment #2) > - when libtool is used as BR: then autoconf and automake are redundant the latter two have been removed from BuildRequire > - parallel make is not used - see > https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make make called with %{_smp_mflags} > - you should include README as %doc added Package is APPROVED, thanks for the update. In the future, please, increase the release for each published package iteration. Don't forget to close this bug after the package is imported and built. New Package CVS Request ======================= Package Name: xorg-x11-drv-synaptics Short Description: Xorg X11 synaptics input driver Owners: whot Branches: F-9 InitialCC: whot Cvsextras Commits: yes cvs done. Package Change Request ====================== Package Name: xorg-x11-drv-synaptics New Branches: F-10 Owners: whot Please create an F-10 branch for stabilization work. cvs done. |