Bug 458617 - Review Request: xorg-x11-drv-synaptics - Xorg X11 synaptics input driver
Summary: Review Request: xorg-x11-drv-synaptics - Xorg X11 synaptics input driver
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 226446 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-11 00:53 UTC by Peter Hutterer
Modified: 2008-10-03 17:09 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-12 07:38:15 UTC
Type: ---
Embargoed:
dan: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peter Hutterer 2008-08-11 00:53:01 UTC
Spec URL: http://whot.fedorapeople.org/synaptics/xorg-x11-drv-synaptics.spec
SRPM URL: http://whot.fedorapeople.org/synaptics/xorg-x11-drv-synaptics-0.15.0-1.fc9.src.rpm
Description: 
This is a driver for the Synaptics TouchPad for X.Org. A Synaptics touchpad by
default operates in compatibility mode by emulating a standard mouse. However,
by using a dedicated driver, more advanced features of the touchpad becomes
available.

Features:

    * Movement with adjustable, non-linear acceleration and speed.
    * Button events through short touching of the touchpad.
    * Double-Button events through double short touching of the touchpad.
    * Dragging through short touching and holding down the finger on the
      touchpad.
    * Middle and right button events on the upper and lower corner of the
      touchpad.
    * Vertical scrolling (button four and five events) through moving the
      finger on the right side of the touchpad.
    * The up/down button sends button four/five events.
    * Horizontal scrolling (button six and seven events) through moving the
      finger on the lower side of the touchpad.
    * The multi-buttons send button four/five events, and six/seven events for
      horizontal scrolling.
    * Adjustable finger detection.
      Multifinger taps: two finger for middle button and three finger for
      right button events. (Needs hardware support. Not all models implement
      this feature.)
    * Run-time configuration using shared memory. This means you can change
      parameter settings without restarting the X server.


Reason for this package: the synaptics package currently in Fedora is discontinued upstream, with the maintainer having agreed to a relicensing the source (from GPL to MIT). The new source is hosted in the X.Org repositories, with a new maintainer. This package is merely a move of the synaptics package to the new xorg-x11-drv-synaptics name to be in-line with other xorg packages.
The spec file is a merger of synaptics.spec, and the xorg-x11-drv-evdev.spec (for xorg-related information).

Comment 1 Dan Horák 2008-08-11 06:39:52 UTC
*** Bug 226446 has been marked as a duplicate of this bug. ***

Comment 2 Dan Horák 2008-08-11 09:26:28 UTC
formal review is here, see the notes below

OK	source files match upstream:
	    41eaa1c77af11166ff5ec4abc013076f545bc676  xf86-input-synaptics-0.15.0.tar.bz2
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (MIT). License text included in package.
OK	latest version is being packaged.
OK*	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK*	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

- when libtool is used as BR: then autoconf and automake are redundant 
- parallel make is not used - see https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- you should include README as %doc

Comment 3 Peter Hutterer 2008-08-11 09:51:54 UTC
Thanks!

Updated spec file and srpm available at the URLs above.

(In reply to comment #2)
> - when libtool is used as BR: then autoconf and automake are redundant 

the latter two have been removed from BuildRequire

> - parallel make is not used - see
> https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

make called with %{_smp_mflags}

> - you should include README as %doc

added

Comment 4 Dan Horák 2008-08-11 10:02:08 UTC
Package is APPROVED, thanks for the update. In the future, please, increase the release for each published package iteration.

Don't forget to close this bug after the package is imported and built.

Comment 5 Peter Hutterer 2008-08-12 00:23:41 UTC
New Package CVS Request
=======================
Package Name: xorg-x11-drv-synaptics
Short Description: Xorg X11 synaptics input driver
Owners: whot
Branches: F-9
InitialCC: whot
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-08-12 05:24:22 UTC
cvs done.

Comment 7 Peter Hutterer 2008-10-02 04:31:35 UTC
Package Change Request
======================
Package Name: xorg-x11-drv-synaptics
New Branches: F-10
Owners: whot

Please create an F-10 branch for stabilization work.

Comment 8 Kevin Fenzi 2008-10-03 17:09:38 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.