Bug 466879
| Summary: | Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
huzaifas: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-03 12:18:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 452450 | ||
|
Description
Miroslav Suchý
2008-10-14 10:39:33 UTC
Not much to say here, really. I guess I could point out that most people tend to prefer calling iconv over patching to fix utf8 issues, but that's up to you. * source files match upstream: 4274d1aedcdd6e5ad54f417390dae75bc9231726c7431ab1aee40a507b3748c3 Crypt-GeneratePassword-0.03.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Crypt::GeneratePassword) = 0.03 perl-Crypt-GeneratePassword = 0.03-3.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(Exporter) perl(strict) perl(vars) * %check is present and the one test passes. It's about the minimal useful test suite you can get for a Perl module, but it's there. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. New Package CVS Request ======================= Package Name: perl-Crypt-GeneratePassword Short Description: Generate secure random pronounceable passwords Owners: msuchy Branches: devel F-9 F-10 EL-4 EL-5 InitialCC: Cvsextras Commits: yes cvs done Any reason this ticket is still open? Hmm, there is one problem. We both missed that is package is already included: https://bugzilla.redhat.com/show_bug.cgi?id=452458 But it now bring the situation that I'm owner of F-10, F-9, EL-4 and EL-5 branch. And nigelj is owner of devel and F-8. https://admin.fedoraproject.org/pkgdb/packages/name/perl-Crypt-GeneratePassword *** This bug has been marked as a duplicate of bug 452458 *** |