Bug 467414 (mingw32-gnutls)
Summary: | Review Request: mingw32-gnutls - MinGW Windows GnuTLS TLS/SSL encryption library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | berrange, fedora-package-review, herrold, notting, tcallawa |
Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 2.6.4-1.fc10 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-09 22:53:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 454410, 454416, 467325, 467398, 467403, 467410 | ||
Bug Blocks: | 467418, 467421 |
Description
Richard W.M. Jones
2008-10-17 11:27:00 UTC
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/gnutls/mingw32-gnutls.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-gnutls-2.4.2-3.fc10.src.rpm Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/gnutls/mingw32-gnutls.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-gnutls-2.6.3-2.fc11.src.rpm * Fri Jan 23 2009 Richard W.M. Jones <rjones> - 2.6.3-1 - Rebase to native Fedora version 2.6.3. - Enable C++ library. - Use find_lang macro. - Don't build static library. - Rebase MinGW patch to 2.6.3. - +BR mingw32-dlfcn. - +BR mingw32-readline. - Force rebuild of libtool. Review done on: http://homes.merjis.com/~rich/mingw/fedora-rawhide/src/SRPMS/mingw32-gnutls-2.6.3-5.fc11.src.rpm You should be sure to update this to 2.6.4 before you commit to rawhide. == REVIEW == Good: - rpmlint checks return nothing - package meets naming guidelines - package meets MinGW packaging guidelines - same patch and configure opts as normal package - license (GPLv3+ and LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - modified tarball okay - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file It feels odd for these packages to not have proper -devel packages, but I suppose that is just how MinGW is. APPROVED. Thanks for reviewing this. I will prepare a 2.6.4 package before uploading (in fact, now). New Package CVS Request ======================= Package Name: mingw32-gnutls Short Description: MinGW GnuTLS TLS/SSL encryption library Owners: rjones berrange Branches: F-10 EL-5 InitialCC: cvs done. mingw32-gnutls-2.6.4-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-gnutls-2.6.4-1.fc10 mingw32-gnutls-2.6.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |