Bug 467414 (mingw32-gnutls)

Summary: Review Request: mingw32-gnutls - MinGW Windows GnuTLS TLS/SSL encryption library
Product: [Fedora] Fedora Reporter: Richard W.M. Jones <rjones>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: berrange, fedora-package-review, herrold, notting, tcallawa
Target Milestone: ---Flags: tcallawa: fedora‑review+
kevin: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: 2.6.4-1.fc10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-09 18:53:34 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 454410, 454416, 467325, 467398, 467403, 467410    
Bug Blocks: 467418, 467421    

Description Richard W.M. Jones 2008-10-17 07:27:00 EDT
Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=ea00554abe8421a9f5fb4506c9e6b35983a9005e;path=/gnutls/
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-gnutls-2.4.2-2.fc9.src.rpm
Description: MinGW Windows GnuTLS TLS/SSL encryption library

Approved packaging guidelines for MinGW are here:
Comment 2 Richard W.M. Jones 2009-01-25 08:17:52 EST
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/gnutls/mingw32-gnutls.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-gnutls-2.6.3-2.fc11.src.rpm

* Fri Jan 23 2009 Richard W.M. Jones <rjones@redhat.com> - 2.6.3-1
- Rebase to native Fedora version 2.6.3.
- Enable C++ library.
- Use find_lang macro.
- Don't build static library.
- Rebase MinGW patch to 2.6.3.
- +BR mingw32-dlfcn.
- +BR mingw32-readline.
- Force rebuild of libtool.
Comment 3 Tom "spot" Callaway 2009-03-06 15:14:29 EST
Review done on:


You should be sure to update this to 2.6.4 before you commit to rawhide.

== REVIEW ==


- rpmlint checks return nothing
- package meets naming guidelines
- package meets MinGW packaging guidelines
- same patch and configure opts as normal package
- license (GPLv3+ and LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- modified tarball okay
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

It feels odd for these packages to not have proper -devel packages, but I suppose that is just how MinGW is.

Comment 4 Richard W.M. Jones 2009-03-09 11:46:05 EDT
Thanks for reviewing this.  I will prepare a 2.6.4 package before
uploading (in fact, now).
Comment 5 Richard W.M. Jones 2009-03-09 11:47:54 EDT
New Package CVS Request
Package Name: mingw32-gnutls
Short Description: MinGW GnuTLS TLS/SSL encryption library
Owners: rjones berrange
Branches: F-10 EL-5
Comment 6 Kevin Fenzi 2009-03-09 12:01:24 EDT
cvs done.
Comment 7 Fedora Update System 2009-03-09 14:39:01 EDT
mingw32-gnutls-2.6.4-1.fc10 has been submitted as an update for Fedora 10.
Comment 8 Fedora Update System 2009-03-09 18:53:29 EDT
mingw32-gnutls-2.6.4-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.