Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=82a0662b5376fe1a90612ed85628670c902a43d3;path=/libgpg-error/ SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-libgpg-error-1.6-8.fc9.src.rpm Description: MinGW Windows GnuPGP error library Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libgpg-error/mingw32-libgpg-error.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-libgpg-error-1.6-8.fc10.src.rpm
I'd be happy to review this package... the src.rpm link seems to be 503 right now. Is there an updated link I can use?
I'm sorry about that. My webserver was down this morning, but I've just checked and everything should be alright again now.
Koji scratch-build in dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1065724
Sorry for the delay here: OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (LGPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: f3e9870e213518b407a959f8d29cd554 libgpg-error-1.6.tar.bz2 f3e9870e213518b407a959f8d29cd554 libgpg-error-1.6.tar.bz2.orig See below - BuildRequires correct See below - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install MINGW32 - Headers/static libs in -devel subpackage. MINGW32- .pc files in -devel subpackage/requires pkgconfig MINGW32- .so files in -devel subpackage. MINGW32- .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag MINGW32 - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: First off, this is my first mingw32 review, so I am sure I will ask some stupid questions... 1. For buildrequires I see in the build.log: checking for msgfmt... no checking for gmsgfmt... : checking for xgettext... no checking for msgmerge... no ... checking for GNU gettext in libc... no Should you add those to BuildRequires? 2. Any reason you can't use %{?_smp_mflags} with your make? Or does that not work with mingw32 packages? 3. rpmlint of course has a bunch to say... perhaps you could get it to not complain when the package is mingw32-* on a lot of these? Ignore: mingw32-libgpg-error.noarch: W: no-documentation mingw32-libgpg-error.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/bin/gpg-error-config mingw32-libgpg-error.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/gpg-error.h mingw32-libgpg-error.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.dll.a mingw32-libgpg-error.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.la mingw32-libgpg-error.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.dll.a mingw32-libgpg-error.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 mingw32-libgpg-error.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.dll.a Should you be using %find_lang here: mingw32-libgpg-error.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/de/LC_MESSAGES/libgpg-error.mo mingw32-libgpg-error.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/fr/LC_MESSAGES/libgpg-error.mo mingw32-libgpg-error.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/pl/LC_MESSAGES/libgpg-error.mo mingw32-libgpg-error.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/ro/LC_MESSAGES/libgpg-error.mo mingw32-libgpg-error.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/sv/LC_MESSAGES/libgpg-error.mo mingw32-libgpg-error.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/vi/LC_MESSAGES/libgpg-error.mo
(In reply to comment #5) > Sorry for the delay here: Hey no problem, thanks for taking the time to look at this. > 1. For buildrequires I see in the build.log: > > checking for msgfmt... [..] > Should you add those to BuildRequires? Yes, they should be. I have added those in the updated package. > 2. Any reason you can't use %{?_smp_mflags} with your make? > Or does that not work with mingw32 packages? Also a bug, added ... > 3. rpmlint of course has a bunch to say... perhaps you could get it > to not complain when the package is mingw32-* on a lot of these? This page summarises rpmlint warnings: https://fedoraproject.org/wiki/MinGW/Rpmlint > Should you be using %find_lang here: Yes, we should be, and I have added it. Spec file: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libgpg-error/mingw32-libgpg-error.spec SRPM file: http://koji.fedoraproject.org/koji/getfile?taskID=1074597&name=mingw32-libgpg-error-1.6-9.fc11.src.rpm * Thu Jan 22 2009 Richard W.M. Jones <rjones> - 1.6-9 - Verify that we are still matching current native package. - Use auto-buildrequires to identify more accurate list of BRs: + BR gettext (for /usr/bin/msgfmt etc) + BR mingw32-dlfcn + BR mingw32-iconv - Use _smp_mflags. - Use find_lang. A koji scratch build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1074596
That addresses all the issues I saw... so this package is APPROVED.
Thanks Kevin for looking at this. CVS request coming up ...
New Package CVS Request ======================= Package Name: mingw32-libgpg-error Short Description: MinGW Windows GnuPGP error library Owners: rjones lfarkas berrange mingwmaint Branches: EL-5 F-10 InitialCC:
cvs done.
Note however, that "mingwmaint" doesn't seem to be a valid user to add as a co-maintainer.
(In reply to comment #11) > Note however, that "mingwmaint" doesn't seem to be a valid user to add as a > co-maintainer. This is our "mailing list user": https://admin.fedoraproject.org/pkgdb/users/packages/mingwmaint Do I need to add "him" to something else apart from FAS?
This package has been built in Rawhide, F-10 and EL-5.
The mailing list user should just be on initialcc right? A mailing list can't be/shouldn't be a co-maintainer...
mingw32-libgpg-error-1.6-9.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.