Bug 471133

Summary: CONFIG_CRASH should not be set for s390x
Product: [Fedora] Fedora Reporter: Brad Hinson <bhinson>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: karsten, kernel-maint, quintela
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-13 16:57:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    
Attachments:
Description Flags
unset CONFIG_CRASH
none
Compile error during rpmbuild none

Description Brad Hinson 2008-11-11 22:00:03 UTC 
Description of problem:
Compilation error with CONFIG_CRASH set on s390x.  Shouldn't be set on this arch anyway.

I don't fully grasp how this value makes its way into .config, but attaching my hack/patch for reference.

Version-Release number of selected component (if applicable):
kernel-2.6.27.5-32.fc9
Comment 1 Brad Hinson 2008-11-11 22:00:48 UTC 
Created attachment 323265 [details]
unset CONFIG_CRASH
Comment 2 Dave Jones 2008-11-12 00:23:52 UTC 
what's the compilation error ?
afaik, there's no reason that this shouldn't work on s390. It's just a feature subset of /dev/mem
Comment 3 Brad Hinson 2008-11-12 17:47:17 UTC 
Created attachment 323361 [details]
Compile error during rpmbuild
Comment 4 Dave Jones 2008-11-12 18:10:11 UTC 
huh, I thought we used to build this on earlier RHELs. Looks like I was mistaken.

I committed a similar patch to yours (it goes in config-s390x instead, which overrides the setting in config-generic)
Comment 5 Karsten Hopp 2009-02-11 21:28:48 UTC 
*** Bug 485144 has been marked as a duplicate of this bug. ***
Comment 6 Karsten Hopp 2009-02-11 21:32:13 UTC 
this issue isn't fixed in kernel-2.6.29-0.99.rc4.git1.fc11.src.rpm, can you take
a look at it again, please ? We need to build a s390x kernel for F-11 when we branch for RHEL6. Bonus points if the kernel even boots ;-)
Comment 7 Chuck Ebbert 2009-02-28 19:22:13 UTC 
$ grep CRASH configs/*s390*
# CONFIG_CRASH is not set

???
Comment 8 Dave Jones 2009-03-13 16:57:31 UTC 
I killed this driver completely. Crash should be able to use the generic upstream drivers in current Fedora.