Bug 471787

Summary:	Review Request: taginfo - Printer of Tag Information from Media Files
Product:	[Fedora] Fedora	Reporter:	Conrad Meyer <cse.cem+redhatbugz>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-11-19 08:02:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Conrad Meyer 2008-11-16 11:12:42 UTC

Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/taginfo.spec
SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/taginfo-1.2-1.fc9.src.rpm
Description:
Taginfo is a quick implementation of the TagLib API for use in the music
jukebox program Room Juice.  It's meant to be fast, not featureful. Taginfo
reads what tags TagLib can read, which as of this writing are ID3, ID3V2,
Ogg, and FLAC.

Comment 1 Parag AN(पराग) 2008-11-17 05:09:41 UTC

Use CFLAGS in make command as
make %{?_smp_mflags} CFLAGS="${optflags}"

Comment 2 Parag AN(पराग) 2008-11-17 05:12:14 UTC

Review:
+ package builds in mock.
 Koji build =>  http://koji.fedoraproject.org/koji/taskinfo?taskID=935739
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
b709dd6be61260c01d2bbdcb482cc1a6  taginfo-1.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestions 
 1) as per given in comment #1 use cflags before committing to cvs

APPROVED.

Comment 3 Conrad Meyer 2008-11-17 05:17:23 UTC

Thanks!

New Package CVS Request
=======================
Package Name: taginfo
Short Description: Printer of Tag Information from Media Files
Owners: konradm
Branches: F-10 F-9
InitialCC:

Comment 4 Kevin Fenzi 2008-11-19 03:46:43 UTC

cvs done.

Comment 5 Conrad Meyer 2008-11-19 08:02:57 UTC

http://koji.fedoraproject.org/koji/taskinfo?taskID=939479

Build in rawhide, closing.