Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/taginfo.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/taginfo-1.2-1.fc9.src.rpm Description: Taginfo is a quick implementation of the TagLib API for use in the music jukebox program Room Juice. It's meant to be fast, not featureful. Taginfo reads what tags TagLib can read, which as of this writing are ID3, ID3V2, Ogg, and FLAC.
Use CFLAGS in make command as make %{?_smp_mflags} CFLAGS="${optflags}"
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=935739 + rpmlint is silent for SRPM and for RPM. + source files match upstream. b709dd6be61260c01d2bbdcb482cc1a6 taginfo-1.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions 1) as per given in comment #1 use cflags before committing to cvs APPROVED.
Thanks! New Package CVS Request ======================= Package Name: taginfo Short Description: Printer of Tag Information from Media Files Owners: konradm Branches: F-10 F-9 InitialCC:
cvs done.
http://koji.fedoraproject.org/koji/taskinfo?taskID=939479 Build in rawhide, closing.