Bug 475098
| Summary: | Review Request: python-Traits - Explicitly typed attributes for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | dcantrell, fedora-package-review, notting, orion |
| Target Milestone: | --- | Flags: | jkeating:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 3.0.2-2.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-07 15:22:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 481727, 482216 | ||
|
Description
Rakesh Pandit
2008-12-07 19:16:18 UTC
Taking review. * python define correct * Name/Summary/Group/URL all correct * Buildroot def is fine * Builds Ok in mock * License is wrong, there are multiple licenses in this package, due to various image files. BSD 3-clause, Eclipse Public License, LGPL, GPLv2 Many files in enthought/traits/protocols/ have no license headers, and are in fact from a different project, PyProtocols Many files in enthought/traits/tests/ have no license headers enthought/traits/ui/editors_gen.py is licensed under GPLv2(thus +) MANY things in examples/ have no license information Most things in integrationtests/ have no license information * buildroot is sane * %prep,%build,%files,%clean all seem fine * %files OK * changelog OK * rpmlint output: python-Traits.i386: E: non-standard-executable-perm /usr/lib/python2.6/site-packages/enthought/traits/ctraits.so 0775 python-Traits.i386: E: non-standard-executable-perm /usr/lib/python2.6/site-packages/enthought/traits/protocols/_speedups.so 0775 ** SUMMARY ** This needs a close examination of the licenses of the files and a correct License field. Permissions need to be fixed. I have dropped a mail upstream to get as much as things clear for licenses. https://svn.enthought.com/enthought/ticket/1765 Upstream is working on fixing this issue. They planning to make most of the things to BSD 3-clause. Images are in there original license only. So, present license tag will be mix of all those licenses. I will wait for few days and check if they move quickly. If not I will update. The only file in GPLv2+ is actually a mistake done by someone. They are also planning to re-license that if possible. Images have different licenses. For image license breakdown check image_LICENSE.txt file. Except enthought/traits/ui/editors_gen.py which is GPLv2+ all remaining source or image files are in BSD 3-clause license. Confirmed from upstream. They will fix all concerned issues and include license blocks in source locks where it has been missing in future releases. I have kept a note of about different licenses and where more information can be found on just top of license tag which is: BSD and EPL and LGPLv2 and GPLv2+ %changelog * Tue Jan 27 2009 Rakesh Pandit <rakesh> 3.0.2-2 - Fixed permissions for ctraits.so and _speedups.so - Fixed license after confirming from upstream SPEC: http://rakesh.fedorapeople.org/spec/python-Traits.spec SRPM: http://rakesh.fedorapeople.org/srpm/python-Traits-3.0.2-2.fc10.src.rpm @Jesse ping, may you look at this soon ? Thanks OK, looks good now! Thanks Jesse! New Package CVS Request ======================= Package Name: python-Traits Short Description: Explicitly typed attributes for Python Owners: rakesh Branches: F-9 F-10 InitialCC: Cvsextras Commits: yes cvs done python-Traits-3.0.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-Traits-3.0.2-2.fc10 python-Traits-3.0.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/python-Traits-3.0.2-2.fc9 python-Traits-3.0.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. python-Traits-3.0.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: python-Traits New Branches: el6 Owners: orion InitialCC: Git done (by process-git-requests). |