Red Hat Bugzilla – Bug 475098
Review Request: python-Traits - Explicitly typed attributes for Python
Last modified: 2013-05-02 07:06:29 EDT
The traits package developed by Enthought provides a special type
definition called a trait. Although they can be used as normal Python object
attributes, traits also have several additional characteristics:
* Initialization: A trait can be assigned a default value.
* Validation: A trait attribute's type can be explicitly declared.
* Delegation: The value of a trait attribute can be contained either
in another object.
* Notification: Setting the value of a trait attribute can trigger
notification of other parts of the program.
* Visualization: User interfaces that permit the interactive
modification of a trait's value can be automatically constructed
using the trait's definition.
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=985713
* python define correct
* Name/Summary/Group/URL all correct
* Buildroot def is fine
* Builds Ok in mock
* License is wrong, there are multiple licenses in this package, due to various image files. BSD 3-clause, Eclipse Public License, LGPL, GPLv2
Many files in enthought/traits/protocols/ have no license headers, and are in fact from a different project, PyProtocols
Many files in enthought/traits/tests/ have no license headers
enthought/traits/ui/editors_gen.py is licensed under GPLv2(thus +)
MANY things in examples/ have no license information
Most things in integrationtests/ have no license information
* buildroot is sane
* %prep,%build,%files,%clean all seem fine
* %files OK
* changelog OK
* rpmlint output:
python-Traits.i386: E: non-standard-executable-perm /usr/lib/python2.6/site-packages/enthought/traits/ctraits.so 0775
python-Traits.i386: E: non-standard-executable-perm /usr/lib/python2.6/site-packages/enthought/traits/protocols/_speedups.so 0775
** SUMMARY **
This needs a close examination of the licenses of the files and a correct License field.
Permissions need to be fixed.
I have dropped a mail upstream to get as much as things clear for licenses.
Upstream is working on fixing this issue. They planning to make most of the things to BSD 3-clause.
Images are in there original license only. So, present license tag will be mix of all those licenses. I will wait for few days and check if they move quickly. If not I will update.
The only file in GPLv2+ is actually a mistake done by someone. They are also planning to re-license that if possible.
Images have different licenses. For image license breakdown check image_LICENSE.txt file. Except enthought/traits/ui/editors_gen.py which is GPLv2+ all remaining source or image files are in BSD 3-clause license. Confirmed from upstream. They will fix all concerned issues and include license blocks in source locks where it has been missing in future releases.
I have kept a note of about different licenses and where more information can be found on just top of license tag which is:
BSD and EPL and LGPLv2 and GPLv2+
* Tue Jan 27 2009 Rakesh Pandit <firstname.lastname@example.org> 3.0.2-2
- Fixed permissions for ctraits.so and _speedups.so
- Fixed license after confirming from upstream
ping, may you look at this soon ?
OK, looks good now!
New Package CVS Request
Package Name: python-Traits
Short Description: Explicitly typed attributes for Python
Branches: F-9 F-10
Cvsextras Commits: yes
python-Traits-3.0.2-2.fc10 has been submitted as an update for Fedora 10.
python-Traits-3.0.2-2.fc9 has been submitted as an update for Fedora 9.
python-Traits-3.0.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
python-Traits-3.0.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request
Package Name: python-Traits
New Branches: el6
Git done (by process-git-requests).