Bug 481727 - Review Request: python-EnvisageCore - Extensible Application Framework
Summary: Review Request: python-EnvisageCore - Extensible Application Framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 475098 481725 481759
Blocks: 481734 482216
TreeView+ depends on / blocked
 
Reported: 2009-01-27 12:07 UTC by Rakesh Pandit
Modified: 2009-07-03 19:41 UTC (History)
3 users (show)

Fixed In Version: 3.1.0-1.fc11
Clone Of:
Environment:
Last Closed: 2009-06-09 04:51:56 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Rakesh Pandit 2009-01-27 12:07:10 UTC
Description:
Envisage is a Python-based framework for building extensible
applications, that is, applications whose functionality can be
extended by adding "plug-ins". Envisage provides a standard mechanism
for features to be added to an application, whether by the original
developer or by someone else.

SPEC: http://rakesh.fedorapeople.org/spec/python-EnvisageCore.spec
SRPM: http://rakesh.fedorapeople.org/srpm/python-EnvisageCore-3.0.1-1.fc10.src.rpm

Need for Mayavi package

Comment 1 Parag AN(पराग) 2009-02-09 05:44:14 UTC
Review:
+ package builds in mock (rawhide i386).
koji build= >http://koji.fedoraproject.org/koji/taskinfo?taskID=1108595
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
88ce02329f0437505ca1ef429b75e66f  EnvisageCore-3.0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestions:
1) Add examples to %doc

After installed this package I am unable to run test as
python /usr/share/doc/python-EnvisageCore-3.0.1/examples/Hello\ World/hello_world.py 
==> got following traceback error
ImportError: No module named preferences.api

Can this be fixed?

Comment 2 Parag AN(पराग) 2009-03-05 04:29:11 UTC
any updates here?

Comment 3 Rakesh Pandit 2009-03-06 09:52:58 UTC
I don't see why it failed as the only dependency was setupdocs which is already done. So, I have asked upstream and waiting for response:
https://mail.enthought.com/pipermail/enthought-dev/2009-March/020195.html

Between yes I will be moving examples under %docs.

Thanks,

Comment 4 Rakesh Pandit 2009-03-06 10:52:07 UTC
Just confirmed that home page prerequisites were wrong and python-Apptools, python-Traits are dependencies. Will address them ASAP.

Updated dependencies.

Comment 5 Parag AN(पराग) 2009-04-08 04:12:46 UTC
ping?

Comment 6 Rakesh Pandit 2009-05-02 13:48:45 UTC
New dependencies are python-configobj and python-AppTools (under review)

python-AppTools - https://bugzilla.redhat.com/show_bug.cgi?id=481759
URL for download http://rakesh.fedorapeople.org/srpm/python-AppTools-3.1.0-2.fc10.src.rpm

This package has three dependencies:
1.	python-EnthoughtBase - (also undergoing review) - https://bugzilla.redhat.com/show_bug.cgi?id=481738
URL for download http://rakesh.fedorapeople.org/srpm/python-EnthoughtBase-3.0.1-2.fc10.src.rpm
2.	python-TraitsGUI also under review https://bugzilla.redhat.com/show_bug.cgi?id=481701
URL for download http://rakesh.fedorapeople.org/srpm/python-TraitsGUI-3.0.3-3.fc10.src.rpm
     	which has one dependency python-TraitsBackendQt via yum
3.	python-Traits via yum

Now tests run for me. But yeah .. they are supposed to be run as sudo or root.

Updated:
http://rakesh.fedorapeople.org/spec/python-EnvisageCore.spec
http://rakesh.fedorapeople.org/srpm/python-EnvisageCore-3.0.1-2.fc10.src.rpm

Comment 7 Rakesh Pandit 2009-05-24 09:35:47 UTC
ping :) ?

Comment 8 Rakesh Pandit 2009-05-24 09:36:44 UTC
I have anyway confirmed with upstream ... that tests need lot of work and they have wrong dependency over other package in stack .. which otherwise make no sense.

Comment 9 Parag AN(पराग) 2009-06-08 09:15:57 UTC
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1398754

APPROVED.

Comment 10 Rakesh Pandit 2009-06-08 09:31:39 UTC
Thanks,

New Package CVS Request
=======================
Package Name: python-EnvisageCore
Short Description: Extensible Application Framework
Owners: rakesh
Branches: F-9 F-10 F-11
InitialCC:

Comment 11 Jason Tibbitts 2009-06-08 16:29:57 UTC
CVS done.

Comment 12 Fedora Update System 2009-06-09 04:48:06 UTC
python-EnvisageCore-3.0.1-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/python-EnvisageCore-3.0.1-2.fc9

Comment 13 Fedora Update System 2009-06-09 04:49:11 UTC
python-EnvisageCore-3.0.1-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-EnvisageCore-3.0.1-2.fc10

Comment 14 Fedora Update System 2009-06-09 04:49:54 UTC
python-EnvisageCore-3.0.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-EnvisageCore-3.0.1-2.fc11

Comment 15 Fedora Update System 2009-07-03 19:35:32 UTC
python-EnvisageCore-3.1.0-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2009-07-03 19:37:01 UTC
python-EnvisageCore-3.1.0-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2009-07-03 19:40:58 UTC
python-EnvisageCore-3.1.0-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.