Bug 478926
| Summary: | Review Request: globus-gass-copy - Globus Toolkit - Globus Gass Copy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 4.14-1.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-18 11:38:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 453847, 453848, 453851, 478921, 478922, 478923, 478925 | ||
| Bug Blocks: | |||
|
Description
Mattias Ellert
2009-01-06 01:11:54 UTC
New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-gass-copy-4.14-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-gass-copy.spec Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-gass-copy-4.14-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-gass-copy.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus I reviewed this package. There is an rpmlint issue - koji rawhide build is fine http://koji.fedoraproject.org/koji/taskinfo?taskID=1394331 - rpmlints on the RPM's globus-gass-copy-devel.x86_64: W: no-documentation globus-gass-copy-progs.x86_64: W: no-documentation can be ignored * however, when I run rpmlint on the installed package I get these additional rpmlints globus-gass-copy.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libglobus_gass_copy.so.2.2.14 /usr/lib64/libglobus_ftp_control.so.1 globus-gass-copy.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libglobus_gass_copy.so.2.2.14 /usr/lib64/libglobus_gssapi_error.so.2 [lots of them] These kind of rpmlints are also present for globus-ftp-client. Sorry for not noticing this before. Are these fixable? I think this is fixed already. If I download the RPM from your scratch build I get: [ellert@ellert ~]$ rpm -q --requires -p globus-gass-copy-4.14-1.fc12.x86_64.rpm /sbin/ldconfig /sbin/ldconfig globus-common libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libglobus_common.so.0()(64bit) libglobus_ftp_client.so.1()(64bit) libglobus_gass_copy.so.2()(64bit) libglobus_gass_transfer.so.2()(64bit) libglobus_io.so.3()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) As you can see it does not list libglobus_ftp_control.so.1 and libglobus_gssapi_error.so.2 that your rpmlint output complains about. So these unused-direct-shlib-dependency issues are not present in this RPM as far as I can see. Also the log says: /usr/bin/gcc -Wl,--as-needed -shared .libs/globus_gass_copy.o .libs/globus_gass_copy_glob.o -L/usr/lib64 -lglobus_ftp_client -lglobus_gass_transfer -lglobus_ftp_control -lglobus_io -lglobus_gssapi_error -lglobus_gss_assist -lglobus_gssapi_gsi -lglobus_gsi_proxy_core -lglobus_gsi_credential -lglobus_gsi_callback -lglobus_oldgaa -lglobus_gsi_sysconfig -lglobus_gsi_cert_utils -lglobus_openssl -lglobus_xio -lglobus_openssl_error -lglobus_callout -lglobus_proxy_ssl -lglobus_common -lm -lssl -lcrypto -ldl -lz -lltdl -lpthread -m64 -mtune=generic -m64 -m64 -Wl,-soname -Wl,libglobus_gass_copy.so.2 -o .libs/libglobus_gass_copy.so.2.2.14 The -Wl,--as-needed should fix this - and it looks as it does. If I run rpmlint on the installed packages here I get no warnings: [ellert@ellert ~]$ rpmlint globus-ftp-client 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ellert@ellert ~]$ rpmlint globus-gass-copy 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Ahh, sorry. I just installed F-11 and my mock configuration wasn't picking up the new globus-core build from updates. I was building against the oldest one. So there are no issues anywhere except in my mock configuration. --------------------------------------------------- This package (globus-gass-copy) is APPROVED by oget --------------------------------------------------- Thank you for the review. New Package CVS Request ======================= Package Name: globus-gass-copy Short Description: Globus Toolkit - Globus Gass Copy Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: CVS done. globus-gass-copy-4.14-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-gass-copy-4.14-1.fc10 globus-gass-copy-4.14-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-gass-copy-4.14-1.fc11 globus-gass-copy-4.14-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-gass-copy-4.14-1.fc9 globus-gass-copy-4.14-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. globus-gass-copy-4.14-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. globus-gass-copy-4.14-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |