Bug 478923 - Review Request: globus-ftp-client - Globus Toolkit - GridFTP Client Library
Summary: Review Request: globus-ftp-client - Globus Toolkit - GridFTP Client Library
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Orcan Ogetbil
QA Contact: Fedora Extras Quality Assurance
Depends On: gpt 453848 453851 478920 478922
Blocks: 478926
TreeView+ depends on / blocked
Reported: 2009-01-06 01:08 UTC by Mattias Ellert
Modified: 2009-06-16 02:07 UTC (History)
3 users (show)

Fixed In Version: 3.14-1.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-06-16 01:37:45 UTC
Type: ---
oget.fedora: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Mattias Ellert 2009-01-06 01:08:15 UTC
Spec URL: http://www.grid.tsl.uu.se/repos/globus/info/globus-ftp-client.spec
SRPM URL: http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-ftp-client-3.14-0.3.fc10.src.rpm

The Globus Toolkit is an open source software toolkit used for
building Grid systems and applications. It is being developed by the
Globus Alliance and many others all over the world. A growing number
of projects and companies are using the Globus Toolkit to unlock the
potential of grids for their cause.

The globus-ftp-client package contains:
GridFTP Client Library

BuildRequires:	grid-packaging-tools
BuildRequires:	globus-xio-popen-driver-devel
BuildRequires:	globus-common-devel >= 4
BuildRequires:	globus-ftp-control-devel >= 1
BuildRequires:	globus-core-devel >= 4

Based on the globus toolkit 4.2.1 release.

Applied patches submitted upstream:

Remove some doxygen warnings:

Dereferencing of type-punned pointers:

Comment 1 Mattias Ellert 2009-03-16 00:02:05 UTC
New version
- Added s390x as 64 bit arch
- Added comment documenting source
- Adapt to changes in the globus-core package


Comment 2 Mattias Ellert 2009-04-17 13:45:10 UTC
Package updated due to new packaging guidelines
- Change defines to globals
- Remove explicit requires on library packages


Draft packaging guidelines for Globus packages are now available:

Comment 3 Orcan Ogetbil 2009-06-03 05:09:18 UTC
There is a tiny issue. Otherwise the package is fine

- rpmlint
   globus-ftp-client-devel.x86_64: W: no-documentation
can be ignored

- koji rawhide build is fine:

* Please fix this warning
   globus_ftp_client_restart_marker.c:710: warning: format '%n' expects type 'int *', but argument 5 has type 'globus_size_t *'

This package (globus-ftp-client) is APPROVED by oget

Comment 4 Mattias Ellert 2009-06-03 07:40:25 UTC
Thank you for the review - I'll fix the warning...

New Package CVS Request
Package Name: globus-ftp-client
Short Description: Globus Toolkit - GridFTP Client Library
Owners: ellert
Branches: F-9 F-10 F-11 EL-4 EL-5

Comment 5 Jason Tibbitts 2009-06-03 16:54:39 UTC
CVS done.

Comment 6 Fedora Update System 2009-06-04 04:35:14 UTC
globus-ftp-client-3.14-1.fc10 has been submitted as an update for Fedora 10.

Comment 7 Fedora Update System 2009-06-04 04:35:20 UTC
globus-ftp-client-3.14-1.fc9 has been submitted as an update for Fedora 9.

Comment 8 Fedora Update System 2009-06-04 04:35:25 UTC
globus-ftp-client-3.14-1.fc11 has been submitted as an update for Fedora 11.

Comment 9 Fedora Update System 2009-06-16 01:37:40 UTC
globus-ftp-client-3.14-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-06-16 01:46:16 UTC
globus-ftp-client-3.14-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-06-16 02:07:23 UTC
globus-ftp-client-3.14-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.