Red Hat Bugzilla – Bug 478922
Review Request: globus-ftp-control - Globus Toolkit - GridFTP Client Control Library
Last modified: 2010-03-17 14:06:26 EDT
Spec URL: http://www.grid.tsl.uu.se/repos/globus/info/globus-ftp-control.spec SRPM URL: http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-ftp-control-2.10-0.3.fc10.src.rpm Description: The Globus Toolkit is an open source software toolkit used for building Grid systems and applications. It is being developed by the Globus Alliance and many others all over the world. A growing number of projects and companies are using the Globus Toolkit to unlock the potential of grids for their cause. The globus-ftp-control package contains: GridFTP Client Control Library BuildRequires: grid-packaging-tools BuildRequires: globus-common-devel >= 3 BuildRequires: globus-gss-assist-devel >= 3 BuildRequires: globus-io-devel >= 6 BuildRequires: globus-gssapi-gsi-devel >= 4 BuildRequires: globus-core-devel >= 4 Based on the globus toolkit 4.2.1 release. Applied patches submitted upstream: Make package descriptions unique: http://bugzilla.globus.org/bugzilla/show_bug.cgi?id=6589 Remove some doxygen warnings: http://bugzilla.globus.org/bugzilla/show_bug.cgi?id=6590 Dereferencing of type-punned pointers: http://bugzilla.globus.org/bugzilla/show_bug.cgi?id=6603
New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-ftp-control-2.10-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-ftp-control.spec
Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-ftp-control-2.10-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-ftp-control.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus
I reviewed this package and found one minor issue - koji rawhide build is fine http://koji.fedoraproject.org/koji/taskinfo?taskID=1385107 * These type of warnings may indicate misbehavior in 64bit systems warning: format '%d' expects type 'int', but argument 4 has type 'globus_size_t' Can you patch this up? Swapping %d with %zd will probably solve the issue. - rpmlint globus-ftp-control-devel.x86_64: W: no-documentation can be ignored Otherwise, the package is good to go. Please take care of the above warnings before you commit. ----------------------------------------------------- This package (globus-ftp-control) is APPROVED by oget -----------------------------------------------------
Thank you for the review - I'll fix those warnings... New Package CVS Request ======================= Package Name: globus-ftp-control Short Description: Globus Toolkit - GridFTP Client Control Library Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC:
CVS done.
Package available in devel.
globus-ftp-control-2.10-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-ftp-control-2.10-1.fc10
globus-ftp-control-2.10-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-ftp-control-2.10-1.fc9
globus-ftp-control-2.10-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-ftp-control-2.10-1.fc11
globus-ftp-control-2.10-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
globus-ftp-control-2.10-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
globus-ftp-control-2.10-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: globus-ftp-control Updated Description: Globus Toolkit - GridFTP Control Library Upstream changed their package description in their new release. This change is requested to reflect this.
No need to do a cvs request for these. They update as your update your package. ;) It's already correct.