Bug 481196
| Summary: | dosfslabel returns code 1 upon success. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | dosfstools | Assignee: | Stepan Kasal <kasal> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | kasal, pfrields, pterjan |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-29 16:19:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
*** This bug has been marked as a duplicate of bug 468050 *** |
Description of problem: The dosfslabel tool returns error code 1, even if it was successful. The code is currently: return fs_close(rw) ? 1 : 0; where fs_close returns 1 if something was written, and 0 else. This test could be inverted as writing means success, but reading the code I don't think it can fail anyway as neither write_label or fs_write does any check so I think it could probably just always return 0.