Bug 481196 - dosfslabel returns code 1 upon success.
Summary: dosfslabel returns code 1 upon success.
Keywords:
Status: CLOSED DUPLICATE of bug 468050
Alias: None
Product: Fedora
Classification: Fedora
Component: dosfstools
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Stepan Kasal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-22 17:42 UTC by Luke Macken
Modified: 2016-09-20 02:39 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-01-29 16:19:16 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Luke Macken 2009-01-22 17:42:33 UTC
Description of problem:

The dosfslabel tool returns error code 1, even if it was successful.

The code is currently:

    return fs_close(rw) ? 1 : 0;

where fs_close returns 1 if something was written, and 0 else.

This test could be inverted as writing means success, but reading the
code I don't think it can fail anyway as neither write_label or fs_write
does any check so I think it could probably just always return 0.

Comment 1 Stepan Kasal 2009-01-29 16:19:16 UTC

*** This bug has been marked as a duplicate of bug 468050 ***


Note You need to log in before you can comment on or make changes to this bug.