Bug 486155

Summary: trousers %pre script fails to create tss user and group
Product: [Fedora] Fedora Reporter: Michal Schmidt <mschmidt>
Component: trousersAssignee: Kent Yoder <key>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: medium    
Version: rawhideCC: ejratl, eparis, key, xjakub
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: trousers-0.3.1-16.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-06 22:07:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fix groupadd and make it build
none
fix groupadd and make it build none

Description Michal Schmidt 2009-02-18 17:17:42 UTC
Created attachment 332419 [details]
fix groupadd and make it build

Description of problem:
The %pre script contains a typo which causes a failure to create the tss group:

getent group tss >/dev/null || groupadd -g 59 r tss
A dash is missing, it should be:
getent group tss >/dev/null || groupadd -g 59 -r tss

Version-Release number of selected component (if applicable):
trousers-0.3.1-13.fc11.x86_64

How reproducible:
always

Steps to Reproduce:
1. yum install trousers
  
Actual results:
While the %pre script is running, you can see groupadd printing its usage instructions. The group and the user are not created.

Expected results:
Should create tss user and group.

Additional info:
I'm attaching a patch fixing this problem. A scratch build in Koji failed because of strict aliasing violations in the tools/ directory. I worked-around it by disabling strict aliasing for the tools. They are not part of the resulting package anyway.

Comment 1 Michal Schmidt 2009-02-18 17:20:21 UTC
Created attachment 332421 [details]
fix groupadd and make it build

I sent a wrong file by mistake previously.

Comment 2 Michal Schmidt 2009-04-08 14:38:54 UTC
Any comments, please? RPM scriptlets have to work.
Thanks.

Comment 3 Milos Jakubicek 2009-04-28 11:49:50 UTC
*** Bug 494424 has been marked as a duplicate of this bug. ***

Comment 4 Michal Schmidt 2009-05-03 14:51:01 UTC
Milos,

I see you're a provenpackager and you recently fixed the FTBFS. Could you also add the missing dash in the %pre script so that adding the tss group works?

Thanks,
Michal

Comment 5 Milos Jakubicek 2009-05-06 22:07:57 UTC
Fixed in F-10, F-11 and devel branches (F-9 not affected), I have also requested a freeze break for F-11: https://fedorahosted.org/rel-eng/ticket/1750