Bug 486155 - trousers %pre script fails to create tss user and group
Summary: trousers %pre script fails to create tss user and group
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: trousers
Version: rawhide
Hardware: All
OS: Linux
medium
high
Target Milestone: ---
Assignee: Kent Yoder
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 494424 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-02-18 17:17 UTC by Michal Schmidt
Modified: 2009-05-06 22:07 UTC (History)
4 users (show)

Fixed In Version: trousers-0.3.1-16.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-06 22:07:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fix groupadd and make it build (3.44 KB, patch)
2009-02-18 17:17 UTC, Michal Schmidt
no flags Details | Diff
fix groupadd and make it build (3.28 KB, patch)
2009-02-18 17:20 UTC, Michal Schmidt
no flags Details | Diff

Description Michal Schmidt 2009-02-18 17:17:42 UTC
Created attachment 332419 [details]
fix groupadd and make it build

Description of problem:
The %pre script contains a typo which causes a failure to create the tss group:

getent group tss >/dev/null || groupadd -g 59 r tss
A dash is missing, it should be:
getent group tss >/dev/null || groupadd -g 59 -r tss

Version-Release number of selected component (if applicable):
trousers-0.3.1-13.fc11.x86_64

How reproducible:
always

Steps to Reproduce:
1. yum install trousers
  
Actual results:
While the %pre script is running, you can see groupadd printing its usage instructions. The group and the user are not created.

Expected results:
Should create tss user and group.

Additional info:
I'm attaching a patch fixing this problem. A scratch build in Koji failed because of strict aliasing violations in the tools/ directory. I worked-around it by disabling strict aliasing for the tools. They are not part of the resulting package anyway.

Comment 1 Michal Schmidt 2009-02-18 17:20:21 UTC
Created attachment 332421 [details]
fix groupadd and make it build

I sent a wrong file by mistake previously.

Comment 2 Michal Schmidt 2009-04-08 14:38:54 UTC
Any comments, please? RPM scriptlets have to work.
Thanks.

Comment 3 Milos Jakubicek 2009-04-28 11:49:50 UTC
*** Bug 494424 has been marked as a duplicate of this bug. ***

Comment 4 Michal Schmidt 2009-05-03 14:51:01 UTC
Milos,

I see you're a provenpackager and you recently fixed the FTBFS. Could you also add the missing dash in the %pre script so that adding the tss group works?

Thanks,
Michal

Comment 5 Milos Jakubicek 2009-05-06 22:07:57 UTC
Fixed in F-10, F-11 and devel branches (F-9 not affected), I have also requested a freeze break for F-11: https://fedorahosted.org/rel-eng/ticket/1750


Note You need to log in before you can comment on or make changes to this bug.