Bug 487795

Summary:	(gcc?) RED! gnome-terminal displays all text with red background
Product:	[Fedora] Fedora	Reporter:	Warren Togami <wtogami>
Component:	gcc	Assignee:	Jakub Jelinek <jakub>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	behdad, bgamari, bnocera, bugs, eparis, felix, jakub, jlaska, jlayton, jmccann, kmcmartin, mclasen, michal, mtasaka, nicolas.mailhot, rstrode, sangu.fedora, seandarcy, tmraz, tomek, vonbrand, wcohen
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-04 20:11:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	446451

Description Warren Togami 2009-02-27 21:57:59 UTC

After the mass rebuild, upgraded 32bit laptop to all packages.  All text in gnome-terminal suddenly became black with red background.  Huh?

gnome-terminal-2.25.91-2.fc11.i586
vte-0.19.4-4.fc11.i586

Comment 1 Mamoru TASAKA 2009-02-28 06:26:12 UTC

Recompiling with replacing "-O2" with "-O0" seems to work
for me, so I guess this is related to gcc optimization.

Comment 2 Mamoru TASAKA 2009-02-28 06:29:49 UTC

And also this affects Terminal in XFCE.

Comment 3 Matthias Clasen 2009-02-28 19:16:02 UTC

After some bisecting with #pragma optimize "O0", I found that
adding 

__attribute__((optimize (0)))

to _vte_terminal_insert_char is enough to fix vte.

Comment 4 Matthias Clasen 2009-02-28 19:17:55 UTC

that function is in src/vte.c

Comment 5 Horst H. von Brand 2009-03-01 18:34:44 UTC

I see the same mess with x86_64.

Comment 6 Kyle McMartin 2009-03-01 19:19:21 UTC

My guess is a mis-optimization of the structure copies of defaults.attr, going to do a few builds and compare with 4.3 to test.

Comment 7 Jakub Jelinek 2009-03-01 19:48:40 UTC

Can you please retry with __attribute__((noinline)) instead of optimize (0) on that function to make sure the problem is really in that function and not in the callers?

Comment 8 Horst H. von Brand 2009-03-01 23:35:21 UTC

On x86_64 going back to vte-0.19.4-3.fc11.x86_64 doesn't help.

Also, ncursesw gets colors very wrong on gnome-terminal.

Comment 9 Ben Gamari 2009-03-01 23:44:43 UTC

(In reply to comment #8)
> On x86_64 going back to vte-0.19.4-3.fc11.x86_64 doesn't help.
> 
> Also, ncursesw gets colors very wrong on gnome-terminal.
That's odd. I'm on x86_64 and reverting to 0.19.4-3.fc11 worked fine for me.

Comment 10 Ray Strode [halfline] 2009-03-02 02:55:27 UTC

When reverting to older vte's, make sure to run:

gnome-terminal --disable-factory

(or pkill -f gnome-terminal)

to make sure new terminal windows aren't just a new instance from the old gnome-terminal process (with the old vte loaded).

Comment 11 Matthias Clasen 2009-03-02 03:36:08 UTC

Jakub, with __attribute__((noinline)) it is still broken.

Comment 12 Jakub Jelinek 2009-03-02 10:23:21 UTC

Apparently SRA messes things up, temporary workaround -fno-tree-sra.

Comment 13 Horst H. von Brand 2009-03-02 12:19:24 UTC

(In reply to comment #9)
> (In reply to comment #8)
> > On x86_64 going back to vte-0.19.4-3.fc11.x86_64 doesn't help.
> > 
> > Also, ncursesw gets colors very wrong on gnome-terminal.
> That's odd. I'm on x86_64 and reverting to 0.19.4-3.fc11 worked fine for me.

Right. After rebooting with the old vte it does work. Sorry.

Comment 14 Matthias Clasen 2009-03-02 16:01:26 UTC

I've built 0.19.4-5.f11 with a workaround now.

Comment 15 Dan Young 2009-03-02 20:40:16 UTC

*** Bug 488104 has been marked as a duplicate of this bug. ***

Comment 16 sean 2009-03-03 02:03:00 UTC

gnome-terminal-2.25.91-2.fc11.i586    WFM

Thanks for a quick response.

Comment 17 Jakub Jelinek 2009-03-04 20:11:53 UTC

Should be fixed in gcc-4.4.0-0.22.