Bug 488106

Summary:	Review Request: django-notification - User notification management for the Django web framework
Product:	[Fedora] Fedora	Reporter:	Ignacio Vazquez-Abrams <ivazqueznet>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-23 05:06:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	488151, 488963

Description Ignacio Vazquez-Abrams 2009-03-02 18:06:51 UTC

Spec URL: http://ivazquez.fedorapeople.org/packages/django-notification/django-notification.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/django-notification/django-notification-0.1.2-2.src.rpm
Description: Many sites need to notify users when certain events have occurred and to allow configurable options as to how those notifications are to be received.

The project aims to provide a Django app for this sort of functionality. This includes:

    * submission of notification messages by other apps
    * notification messages on signing in
    * notification messages via email (configurable by user)
    * notification messages via feed

Comment 1 Parag AN(पराग) 2009-03-03 07:53:52 UTC

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216036
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
3e485b0e047b70bfb00c783deae9e44b  django-notification-0.1.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ egg file generated from source.

Suggestions:
1) I will suggest to use 
%doc CONTRIBUTORS.txt LICENSE.txt docs/*
will make not to create docs named directory
2) Change %define to %global

APPROVED.

Comment 2 Ignacio Vazquez-Abrams 2009-03-03 09:34:51 UTC

New Package CVS Request
=======================
Package Name: django-notification
Short Description: User notification management for the Django web framework
Owners: ivazquez
Branches: F-9 F-10 EL-5

Comment 3 Kevin Fenzi 2009-03-03 20:43:28 UTC

cvs done.

Comment 4 Parag AN(पराग) 2009-03-23 04:56:01 UTC

If this package is built for all requested branches then can we have this review closed now?