Bug 488107
| Summary: | Review Request: django-pagination - Django pagination tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-23 05:06:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 488151, 488963 | ||
|
Description
Ignacio Vazquez-Abrams
2009-03-02 18:10:44 UTC
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216042 rpmlint output django-pagination.noarch: W: file-not-in-%lang /usr/lib/python2.6/site-packages/pagination/locale/de/LC_MESSAGES/django.mo django-pagination.noarch: W: file-not-in-%lang /usr/lib/python2.6/site-packages/pagination/locale/fr/LC_MESSAGES/django.mo django-pagination.noarch: W: file-not-in-%lang /usr/lib/python2.6/site-packages/pagination/locale/pl/LC_MESSAGES/django.mo you should use lang macro to handle locales. also, I will suggest to use %doc CONTRIBUTORS.txt LICENSE.txt docs/* will make not to create docs named directory The only solution to the locale files in Django for now is to remove them; fixing this is on my todo list. http://ivazquez.fedorapeople.org/packages/django-pagination/django-pagination.spec http://ivazquez.fedorapeople.org/packages/django-pagination/django-pagination-1.0.5-3.src.rpm (In reply to comment #1) > rpmlint output > django-pagination.noarch: W: file-not-in-%lang > /usr/lib/python2.6/site-packages/pagination/locale/de/LC_MESSAGES/django.mo > django-pagination.noarch: W: file-not-in-%lang > /usr/lib/python2.6/site-packages/pagination/locale/fr/LC_MESSAGES/django.mo > django-pagination.noarch: W: file-not-in-%lang > /usr/lib/python2.6/site-packages/pagination/locale/pl/LC_MESSAGES/django.mo > > you should use lang macro to handle locales. (In reply to comment #3) > The only solution to the locale files in Django for now is to remove them; > fixing this is on my todo list. Perhaps what I am doing on rubygem-gettext.spec is useful. http://cvs.fedoraproject.org/viewvc/rpms/rubygem-gettext/devel/rubygem-gettext.spec?revision=1.3 For this package, something like: ------------------------------------------------------------------ %install rm -rf $RPM_BUILD_ROOT %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT # modify find-lang.sh to deal with gettext .mo files under # pagination/locale %{__sed} -e 's|/share/locale/|/pagination/locale/|' \ /usr/lib/rpm/find-lang.sh \ > find-lang-modified.sh sh find-lang-modified.sh %{buildroot} django django.lang find %{buildroot}%{python_sitelib}/pagination/locale -type d | while read dir do echo "%%dir ${dir#%{buildroot}}" >> django.lang done find %{buildroot}%{python_sitelib}/pagination/locale -name \*.po -delete %clean rm -rf $RPM_BUILD_ROOT %files -f django.lang %defattr(-,root,root,-) %doc CONTRIBUTORS.txt LICENSE.txt docs/ %{python_sitelib}/*egg*/ %dir %{python_sitelib}/pagination/ %{python_sitelib}/pagination/__init__.py* %{python_sitelib}/pagination/[m-z]* -------------------------------------------------------------------- (In reply to comment #4) > Perhaps what I am doing on rubygem-gettext.spec is useful. Honestly, I'd rather fix Django's i18n. If that proves infeasible or impossible then I'll take a look a this. But thanks. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1222756 source verified with upstream 7c5d5d017c83685065d864565089cc35 django-pagination-1.0.5.tar.gz rpmlint is clean now. APPROVED. New Package CVS Request ======================= Package Name: django-pagination Short Description: Django pagination tools Owners: ivazquez Branches: F-9 F-10 EL-5 cvs done. If this package is built for all requested branches then can we have this review closed now? |