Bug 488107 - Review Request: django-pagination - Django pagination tools
Summary: Review Request: django-pagination - Django pagination tools
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 488151 488963
TreeView+ depends on / blocked
 
Reported: 2009-03-02 18:10 UTC by Ignacio Vazquez-Abrams
Modified: 2009-03-23 05:06 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-23 05:06:32 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ignacio Vazquez-Abrams 2009-03-02 18:10:44 UTC
Spec URL: http://ivazquez.fedorapeople.org/packages/django-pagination/django-pagination.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/django-pagination/django-pagination-1.0.5-2.src.rpm
Description: A set of utilities for creating robust pagination tools throughout a Django application.

Comment 1 Parag AN(पराग) 2009-03-03 07:38:46 UTC
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216042

rpmlint output
django-pagination.noarch: W: file-not-in-%lang /usr/lib/python2.6/site-packages/pagination/locale/de/LC_MESSAGES/django.mo
django-pagination.noarch: W: file-not-in-%lang /usr/lib/python2.6/site-packages/pagination/locale/fr/LC_MESSAGES/django.mo
django-pagination.noarch: W: file-not-in-%lang /usr/lib/python2.6/site-packages/pagination/locale/pl/LC_MESSAGES/django.mo

you should use lang macro to handle locales.

Comment 2 Parag AN(पराग) 2009-03-03 07:44:02 UTC
also, I will suggest to use 
%doc CONTRIBUTORS.txt LICENSE.txt docs/*
will make not to create docs named directory

Comment 3 Ignacio Vazquez-Abrams 2009-03-04 19:47:18 UTC
The only solution to the locale files in Django for now is to remove them; fixing this is on my todo list.

http://ivazquez.fedorapeople.org/packages/django-pagination/django-pagination.spec
http://ivazquez.fedorapeople.org/packages/django-pagination/django-pagination-1.0.5-3.src.rpm

Comment 4 Mamoru TASAKA 2009-03-04 20:27:59 UTC
(In reply to comment #1)
> rpmlint output
> django-pagination.noarch: W: file-not-in-%lang
> /usr/lib/python2.6/site-packages/pagination/locale/de/LC_MESSAGES/django.mo
> django-pagination.noarch: W: file-not-in-%lang
> /usr/lib/python2.6/site-packages/pagination/locale/fr/LC_MESSAGES/django.mo
> django-pagination.noarch: W: file-not-in-%lang
> /usr/lib/python2.6/site-packages/pagination/locale/pl/LC_MESSAGES/django.mo
> 
> you should use lang macro to handle locales.


(In reply to comment #3)
> The only solution to the locale files in Django for now is to remove them;
> fixing this is on my todo list.

Perhaps what I am doing on rubygem-gettext.spec is useful.
http://cvs.fedoraproject.org/viewvc/rpms/rubygem-gettext/devel/rubygem-gettext.spec?revision=1.3

For this package, something like:
------------------------------------------------------------------
%install
rm -rf $RPM_BUILD_ROOT
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT

# modify find-lang.sh to deal with gettext .mo files under
# pagination/locale
%{__sed} -e 's|/share/locale/|/pagination/locale/|' \
	/usr/lib/rpm/find-lang.sh \
	> find-lang-modified.sh

sh find-lang-modified.sh %{buildroot} django django.lang
find %{buildroot}%{python_sitelib}/pagination/locale -type d | while read dir
do
	echo "%%dir ${dir#%{buildroot}}" >> django.lang
done
find %{buildroot}%{python_sitelib}/pagination/locale -name \*.po -delete

%clean
rm -rf $RPM_BUILD_ROOT

%files -f django.lang
%defattr(-,root,root,-)
%doc CONTRIBUTORS.txt LICENSE.txt docs/
%{python_sitelib}/*egg*/
%dir %{python_sitelib}/pagination/
%{python_sitelib}/pagination/__init__.py*
%{python_sitelib}/pagination/[m-z]*
--------------------------------------------------------------------

Comment 5 Ignacio Vazquez-Abrams 2009-03-04 20:40:12 UTC
(In reply to comment #4)
> Perhaps what I am doing on rubygem-gettext.spec is useful.

Honestly, I'd rather fix Django's i18n. If that proves infeasible or impossible then I'll take a look a this. But thanks.

Comment 6 Parag AN(पराग) 2009-03-05 05:46:36 UTC
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1222756
source verified with upstream
7c5d5d017c83685065d864565089cc35  django-pagination-1.0.5.tar.gz
rpmlint is clean now.

APPROVED.

Comment 7 Ignacio Vazquez-Abrams 2009-03-05 08:23:46 UTC
New Package CVS Request
=======================
Package Name: django-pagination
Short Description: Django pagination tools
Owners: ivazquez
Branches: F-9 F-10 EL-5

Comment 8 Kevin Fenzi 2009-03-05 20:42:01 UTC
cvs done.

Comment 9 Parag AN(पराग) 2009-03-23 04:55:54 UTC
If this package is built for all requested branches then can we have this review closed now?


Note You need to log in before you can comment on or make changes to this bug.