Bug 488173
| Summary: | Package Review: ibus-table-erbi | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Caius Chance <K9> | |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | low | |||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, K9, notting, panemade, petersen, phuang | |
| Target Milestone: | --- | Keywords: | i18n | |
| Target Release: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
|
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 488175 496757 (view as bug list) | Environment: | ||
| Last Closed: | 2009-04-07 08:03:10 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 488010 | |||
| Bug Blocks: | 484650 | |||
|
Description
Caius Chance
2009-03-03 00:11:41 UTC
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi-1.1.0.20090402-1.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1274696 + rpmlint output for SRPM and for RPM. ibus-table-erbi.noarch: E: zero-length /usr/share/doc/ibus-table-erbi-1.1.0.20090402/AUTHORS ==> can be fixed by removing AUTHORS file. + source files match upstream url 5b36a300b07cb6eb74be84f74ae63a4b ibus-table-erbi-1.1.0.20090402.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + ibus-table-createdb scriptlet used. + file permissions are appropriate. + Not a GUI App. Suggestions: 1) Drop AUTHORS files from %doc as rpmlint message reported as ibus-table-erbi.noarch: E: zero-length /usr/share/doc/ibus-table-erbi-1.1.0.20090402/AUTHORS 2) try adding contents to Changelog file in upstream and add it as %doc SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi-1.1.0.20090403-1.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. ping Can you add Changelog as %doc as asked already in comment#2 ? SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi-1.1.0.20090403-2.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. APPROVED. Package Name: ibus-table-erbi Short Description: Erbi input method for ibus-table Owners: cchance Branches: devel InitialCC: i18n-team What about search on license/origin of the Erbi table? license is GPLv3+ from COPYING file as erbi_qs.txt file mentions only "GPL" license. cvs admin done I too had discussion with upstream and he said correct license is GPLv2. Can you correct that in upstream tarball and then build new SRPM and import that in cvs as cvs module is ready now? SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi-1.1.0.20090407-1.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. FYI it couldn't be built atm because dependency problems of its depending packages. Tested in mock. SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi-1.1.0.20090407-2.fc11.src.rpm Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-erbi.spec Description: A split from ibus-table-chinese, which was sub-package of ibus-table. built to rawhide Package Change Request ====================== Package Name: ibus-table-erbi New Branches: F-10 Owners: cchance cvs done. |