Bug 490438 (rhn-client-tools)

I'll start reviewing this package.

ping?

Okay, sorry about taking so long for the first glance...

At the moment I see two issues against the current guidelines:

1. Missing .desktop files

I know for a fact that Red Hat Enterprise Linux 3-5 has a GUI for 'rhn_register' and based on what I'm seeing I'm fairly sure you haven't taken it away, so per https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files it really needs a .desktop file so users can find it in the menus.

2. Python module locations

I'm not sure how set in stone this is, but w/ our Python Guidelines, python modules are prefered to be in %{python_sitelib}/modulename/foo.* (https://fedoraproject.org/wiki/Packaging/Python#System_Architecture) would moving these libraries cause any issues with rhn_register etc?

As per our discussion on IRC, I also mentioned about the ownership of a couple of directories...

/etc/sysconfig/rhn/allowed-actions/
/etc/sysconfig/rhn/allowed-actions/script/

Should these be owned by rhn-client-tools or is there going to be another package that provides the rhncfg packages that check for files under these directories?

Updated SPEC: http://miroslav.suchy.cz/fedora/rhn-client-tools/rhn-client-tools.spec
SRPM: http://miroslav.suchy.cz/fedora/rhn-client-tools/rhn-client-tools-0.4.23-1.src.rpm

I added .desktop file (it is my first .desktop, hope I done it correctly).
I added allowed-actions ownership.

And about the python location... I asked and got these response:
Well as the guidelines say, we have our python *modules* (eg: rhnlib) in python_sitelib. I don't really consider our server/client code to be a utility module that belongs to sitelib and as far as I see its placed right in /usr/share/. Of course its before my time this decision was made, but I think its the right one. We should not have code in sitelib unless its a module that could be used generically. Anyway, thats my take. All they have to do is add that path to their PYTHONPATH. I don't think python guidelines enforce all the code to be in python-sitelibs anywhere. 
 -- Prad

Ops, the previous one did not build....

Updated SPEC:
http://miroslav.suchy.cz/fedora/rhn-client-tools/rhn-client-tools.spec
SRPM:
http://miroslav.suchy.cz/fedora/rhn-client-tools/rhn-client-tools-0.4.24-1.src.rpm

I agree with Prad's comments on Python locations.  You really wouldn't reuse this code, so it belongs in /usr/share as an application not a development tool.

Builds in mock for EL5.  I am currently unable to check rawhide due current technical difficulties on my side :)

I am in favor of changing the name of the log file and logrotate file.  I realize legacy systems are using up2date for the log name, but since that tool has been phased out, I think the naming of the log file should be also; however this is a package review, and not a developer/design review....


The package looks good to me, but I'd like Nigel to look at it once more.

Okay, couple of things here that I've just noticed:

 * Icon Cache: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
   - Without the icon cache no Icon appears in the menus (ouch)
 * .desktop file
   - the menu entry lands on my F10 box in System->Preferences with the name 'rhn_register' - this isn't very descriptive imo
   - I'd also say it's more Administration not Preferences

A .desktop file that solves this would be something like:

----
[Desktop Entry]
Encoding=UTF-8
Name=Update Registration
GenericName=Register for software updates from Spacewalk/Satellite/Red Hat Network
Comment=Register to Spacewalk/Satellite/Red Hat Network.
Exec=rhn_register
Icon=up2date
Terminal=false
Type=Application
Categories=System;Settings;X-Red-Hat-Base;
----

This makes it appear as "Update Registration" to be honest you may want to call this "RHN Registration".

 * Broken deps
   - rhn-client-tools depends on yum-rhn-plugin which will apparently be a circular dependency when it gets put forward to review (this is bad)
   - rhn-setup depends on rhnsd which I can't seem to find

Sorry for long delays, been quiet busy...
http://miroslav.suchy.cz/fedora/rhn-client-tools/rhn-client-tools.spec
http://miroslav.suchy.cz/fedora/rhn-client-tools/rhn-client-tools-0.7.1-1.src.rpm

I changed .desktop according your suggestion.
I move dependecy on yum-rhn-plugin to rhn-check, where it should be.

But I'm not sure about rhn-setup and rhnsd.
rhn-setup is subpackage of rhn-client-tools, rhnsd is standalone package whose review will follow shortly. rhnsd require rhn-check (again subpackage of rhn-client-tools). So I can not submit review till rhn-client-tools are accepted. I'm not sure how to fix this. And I would like to avoiding to merging those two packages.

Hi Miroslav,

Everything looks good now, I'm going to give this the big fedora‑review+ and approve the package.

While nothing is blocking you at this stage from requesting CVS/Submitting a Build I will mention that because of the dependencies between SRPMs that you may want to wait before building until they are approved so you don't get broken dependency e-mails everywhere.

New Package CVS Request
=======================
Package Name: rhn-client-tools
Short Description: Support programs and libraries for Red Hat Network or Spacewalk
Owners: msuchy
Branches: F-11, F-12
InitialCC:

CVS done.