Bug 481668 (spacewalk-koan) - Review Request: spacewalk-koan: provides integration between spacewalk and koan.
Summary: Review Request: spacewalk-koan: provides integration between spacewalk and koan.
Keywords:
Status: CLOSED NEXTRELEASE
Alias: spacewalk-koan
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: rhn-client-tools
Blocks: F-Spacewalk
TreeView+ depends on / blocked
 
Reported: 2009-01-26 22:42 UTC by Mike McCune
Modified: 2009-10-01 07:29 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-10-01 07:29:36 UTC
Type: ---
Embargoed:
dennis: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mike McCune 2009-01-26 22:42:00 UTC
Spec URL: http://mmccune.fedorapeople.org/spacewalk-koan-0.1.6/spacewalk-koan.spec
SRPM URL: http://mmccune.fedorapeople.org/spacewalk-koan-0.1.6-1.fc9.src.rpm

Description: 
spacewalk-koan is python code that serves as a bridge between Spacewalk's client side functionality and the koan package. It allows users in Spacewalk's web application to direct a client to kickstart itself or a virtual machine through the use of the koan command.

This is part of the client-side spacewalk tools.

Comment 1 Dennis Gilmore 2009-01-27 01:09:04 UTC
needs to use system defined macros.
needs proper obsoletes/provides instead of the conflict
needs full url to the source tarball
rhel version check needs fixing
own directories created.

hey all need adressing.

Comment 3 Dennis Gilmore 2009-01-27 02:35:32 UTC
builds fine in mock
uses macros consistently
Requires/Obsoletes/Provides are sane


Would be nice to add a copy of the license in the tarball and include it in the docs would quieten down rpmlint
spacewalk-koan.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

sha1sum spacewalk-koan-0.1.6.tar.gz ../SOURCES/spacewalk-koan-0.1.6.tar.gz
de6fde08a8cf821bfc7f4f10adc17c6dcfbfac89  spacewalk-koan-0.1.6.tar.gz
de6fde08a8cf821bfc7f4f10adc17c6dcfbfac89  ../SOURCES/spacewalk-koan-0.1.6.tar.gz


once rhn-check is in ill approve this

Comment 4 Miroslav Suchý 2009-09-23 13:17:19 UTC
rhn-client-tools is approved and built. I suppose this review can be approved - Dennis?
Also, if Mike is not interested in this review any more, I can take over. Mike?

Comment 5 Dennis Gilmore 2009-09-23 14:23:39 UTC
approved

Comment 6 Miroslav Suchý 2009-09-30 15:49:56 UTC
New Package CVS Request
=======================
Package Name: spacewalk-koan
Short Description: Support package for spacewalk koan interaction
Owners: msuchy
Branches: F-11, F-12
InitialCC:

Comment 7 Mike McCune 2009-09-30 15:51:50 UTC
handing over to msuchy as maintainer.

Comment 8 Kevin Fenzi 2009-09-30 23:48:04 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.