Bug 490725
| Summary: | Review Request: geanyvc - Version Controler plugin for geany | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre-YvesChibon <pingou> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade, raj.dev.redhat |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.5-4.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-02 09:02:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pierre-YvesChibon
2009-03-17 18:19:10 UTC
I will review this. 1)koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1250821 missing intltool 2) License looks to be GPLv2+ just found this review already submitted https://bugzilla.redhat.com/show_bug.cgi?id=458773 (In reply to comment #2) > 1)koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1250821 > missing intltool > 2) License looks to be GPLv2+ I'll correct these and upload a new spec/srpm > just found this review already submitted > https://bugzilla.redhat.com/show_bug.cgi?id=458773 Since there has been no change in the bug since October 2008 I left a comment there asking if the reporter was still interested. Let's see if the reporter is still present :) SRPM: http://pingou.fedorapeople.org/RPMs/geanyvc-0.5-2.fc10.src.rpm SPEC: http://pingou.fedorapeople.org/RPMs/geanyvc.spec KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=1250871 Thanks :) What should we do ? *** Bug 458773 has been marked as a duplicate of this bug. *** Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1269712 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 643b4b8ac313754e05c2e60db9c2713c geanyvc-0.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package geanyvc-0.5-2.fc11.i586 => Provides: geanyvc.so Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 rtld(GNU_HASH) + Not a GUI App Suggestions: 1) package should not own /usr/lib/geany as its owned by geany Change %{_libdir}/geany/ to %{_libdir}/geany/* APPROVED. New Package CVS Request ======================= Package Name: geanyvc Short Description: Version controler plugin for geany Owners: pingou Branches: F-9 F-10 InitialCC: CVS done Thanks for the review it is being built :) geanyvc-0.5-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/geanyvc-0.5-4.fc10 geanyvc-0.5-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |