Red Hat Bugzilla – Bug 490725
Review Request: geanyvc - Version Controler plugin for geany
Last modified: 2009-05-02 12:42:32 EDT
Spec URL: http://pingou.fedorapeople.org/RPMs/geanyvc.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs/geanyvc-0.5-1.fc10.src.rpm
geanyvc is plugin that provides a uniform way of accessing the different
version-control systems inside Geany IDE. Only small subset of vc is
implemented, but, hey, you don't need anything besides diff, log, status,
revert and commit most time.
I will review this.
1)koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1250821
2) License looks to be GPLv2+
just found this review already submitted https://bugzilla.redhat.com/show_bug.cgi?id=458773
(In reply to comment #2)
> 1)koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1250821
> missing intltool
> 2) License looks to be GPLv2+
I'll correct these and upload a new spec/srpm
> just found this review already submitted
Since there has been no change in the bug since October 2008 I left a comment there asking if the reporter was still interested. Let's see if the reporter is still present :)
What should we do ?
*** Bug 458773 has been marked as a duplicate of this bug. ***
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1269712
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package geanyvc-0.5-2.fc11.i586 =>
Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 rtld(GNU_HASH)
+ Not a GUI App
1) package should not own /usr/lib/geany as its owned by geany
New Package CVS Request
Package Name: geanyvc
Short Description: Version controler plugin for geany
Branches: F-9 F-10
Thanks for the review it is being built :)
geanyvc-0.5-4.fc10 has been submitted as an update for Fedora 10.
geanyvc-0.5-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.