Bug 492979

Summary: Review Request: python-cliutils - A collection of utilities easing the creation of command line scripts
Product: [Fedora] Fedora Reporter: Jason Friedland <thesuperjason>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: cassmodiah, fedora-package-review, notting, susi.lehtola, thesuperjason
Target Milestone: ---   
Target Release: ---   
Hardware: noarch   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-29 20:08:06 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Jason Friedland 2009-03-30 21:46:34 EDT
Spec URL: http://jason.friedland.id.au/pkg/python-cliutils.spec
SRPM URL: http://jason.friedland.id.au/pkg/python-cliutils-0.1.3-1.fc10.src.rpm
Description: A collection of utilities easing the creation of command line scripts. cliutils is pure Python with no dependencies. At the moment, the module provides three disparate features: Process objects, a command-line argument parsing decorator, and a logging decorator factory.

I still require a sponsor and will add FE-NEEDSPONSOR to the blocks field.
Comment 2 Susi Lehtola 2009-04-03 12:23:39 EDT
- Don't use macros for cat or rm. (Macro for python is in the python guideline
for some reason.)

- Don't use filelist.

- Use %defattr(-,root,root,-)

- Remove empty %post and %postun sections.

- Change

BuildRequires: python, python-devel, python-setuptools

to

BuildRequires: python-setuptools-devel

(BR python is redundant, since python-devel already pulls that in. If you BR
python-setuptools-devel, then it pulls setuptools and python-devel
automatically.)

You don't even need python-setuptools unless you want to build for EPEL. For a plain Fedora spec you'd just need BR: python-devel. (In the python guideline the BR is actually just python.)
Comment 3 Jason Friedland 2009-04-05 05:34:09 EDT
Thanks for the feedback Jussi - I will bear that in mind for future reference.

I have edited the SPEC and re-uploaded the files:

Spec URL: http://jason.friedland.id.au/pkg/python-cliutils.spec
SRPM URL: http://jason.friedland.id.au/pkg/python-cliutils-0.1.3-3.fc10.src.rpm
Comment 4 Susi Lehtola 2009-04-25 03:48:52 EDT
Ping, do you still need a sponsor? Do you have other submissions and have you done reviews of other packages?
Comment 5 Jason Friedland 2009-04-28 04:35:11 EDT
Yes, I still need a sponsor.

I have only reviewed the following package so far: 
https://bugzilla.redhat.com/show_bug.cgi?id=492612

And have also submitted this package: 
https://bugzilla.redhat.com/show_bug.cgi?id=492744
Comment 6 Susi Lehtola 2009-04-28 05:12:49 EDT
Okay, I can sponsor you, but first I need to see that you know the packaging guidelines.

You have done only python packages so far, so I'd like to see reviews of some packages of other types as well. You can also package something yourself; if you don't have anything on your todo list you can look up something from the Fedora Wishlist, just remember to check first if a) the package is already in Fedora or b) there is already a review request of the package in bugzilla

http://fedoraproject.org/wiki/PackageMaintainers/WishList
Comment 7 Susi Lehtola 2009-05-22 12:22:32 EDT
ping?
Comment 8 Jason Tibbitts 2009-06-29 20:08:06 EDT
It's been far too long with no response from the submitter; I'll close this out.