Bug 498136
| Summary: | Review Request: gst-mixer - advanced mixer for GNOME (old gnome-volume-control) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | Package Review | Assignee: | Andreas Thienemann <andreas> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | andreas, bnocera, christoph.wickert, dan, fedora-package-review, itamar, jlaska, leigh123linux, lkundrak, mishu, notting, pahan, stickster, sundaram, tcallawa |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-04 21:35:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Williamson
2009-04-29 02:22:35 UTC
I have tested and for me are good, now I can make the volume higher A few things worth noting:
* You really, really, really don't need those macro defines at the top. Half of them aren't used. Just put the versions in the BuildRequires explicitly.
* Fix the patch to apply without fuzz, please? :) Then, drop the default_fuzz macro define.
* The %{gettext_package} macro is fine, but please use %global instead of %define.
* Are you sure --disable-pulseaudio is correct?
For the first point: I wanted to keep the gst-mixer spec as close as possible to the gnome-media spec, this seemed sensible. So that's where the %define forest comes from. I wouldn't have created it myself. :) If you don't think it's important to have the two specs as similar as possible, I'll happily take them out. The patch applies without fuzz, I think, that setting just came from the gnome-media spec again. I'll take it out. Yes, I want --disable-pulseaudio, because we really just want this mixer to talk to ALSA, not Pulse. The *new* mixer is intended to be the mixer for Pulse. Having said that, it doesn't seem to have any particular effect, because gst-mixer once built still seems able to talk to Pulse - you get a choice in the drop-down in gst-mixer for Pulse mixer as well as ALSA mixer. Sigh. Updated package coming in a few minutes. I'll wait to hear back on the define forest, but change the other bits. OK - spec and .src.rpm updated, same URL. You still really don't need those macros. There is no reason to keep unnecessary cruft in a package, derived from another or not. Also, it is generally good form to bump the release and add an entry to the changelog whenever making a change to the spec file, even during review. OK, bumped to -2.aw_fc11 with that change made: http://adamwill.fedorapeople.org/gst-mixer/gst-mixer-2.26.0-2.aw_fc11.src.rpm ping? Andreas: Sorry for hijacking here, but we really need to have this review done. I hope you don't mind I take over? OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 3d519bc7d812aed8f6e4288b6d3cdf26 gnome-media-2.26.0.tar.bz2 3d519bc7d812aed8f6e4288b6d3cdf26 gnome-media-2.26.0.tar.bz2.orig OK - Package needs ExcludeArch OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Should the Requires: gnome-media be versioned? Or will it cause any issue for this to be out of step with gnome-media? I suspect not, but though I would mention it. 2. rpmlint says: gst-mixer.src:163: W: macro-in-%changelog defines Minor issue... change to %%defines in changelog? :) gst-mixer.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gst-mixer.schemas Can be ignored. I don't see any blockers here, so this package is APPROVED. Fix the %%define and address if gnome-media requires should be versioned before import? I can't really see any big problems that would be caused by not versioning the gnome-media requires, but let me know if I'm missing anything. I'm just about to send a revised -2 package with the changelog changed (it seems a bit recursive to bump to -3 and add a changelog entry to say I changed the changelog...:>) OK, it's up now. Same URL as the previous -2 package. Looks dandy. Feel free to request cvs. New Package CVS Request ======================= Package Name: gst-mixer Short Description: legacy mixer for GNOME Owners: adamwill Branches: F-11 InitialCC: cvs done. ok, review is complete, rawhide build is done. thanks very much, kevin. |