Bug 500247

Summary:	Pre-Review Request: plexus-containers - Containers for Plexus
Product:	[Fedora] Fedora	Reporter:	Fernando Nasser <fnasser>
Component:	Package Review	Assignee:	Andrew Overholt <overholt>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, overholt
Target Milestone:	---	Flags:	overholt: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-08-20 17:20:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	429551

Description Fernando Nasser 2009-05-11 21:58:47 UTC

Package needed for Maven 2.0.8

Spec URL: http://people.fedoraproject.org/~fnasser/plexus-containers.spec

SRPM URL: http://people.fedoraproject.org/~fnasser/plexus-containers-1.0-0.1.a34.5.jpp6.src.rpm

Description: 
The Plexus project seeks to create end-to-end developer tools for
writing applications. At the core is the container, which can be
embedded or for a full scale application server. There are many
reusable components for hibernate, form processing, jndi, i18n,
velocity, etc. Plexus also includes an application server which
is like a J2EE application server, without all the baggage.

Comment 1 Andrew Overholt 2009-05-14 13:56:12 UTC

- the license field should be "ASL 2.0" [1]
- there are three sources with no URLs
- using the instructions for generating the source tarball, I get a lot of differences ... perhaps it's the "-34" vs. the "-44"?

[1]
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names

Comment 2 Fernando Nasser 2009-05-15 16:00:49 UTC

Actually, "ASL 2.0 and Plexus". See plexus-classworlds Pre-Review.

The Source files with no URL or no instructions on how to obtain are like Patch files, produced by the packager.  This has been a default for years, perhaps someone should start a Guidelines discussion about local artifacts in general.

Yes, you are right, it should be 34.

The new spec file is in the same place and we now have:

SRPM URL:
http://people.fedoraproject.org/~fnasser/plexus-containers-1.0-0.1.a34.6.jpp6.src.rpm

with the fixes requested.

Thanks!

Comment 3 Andrew Overholt 2009-05-15 17:01:34 UTC

Things look good to me.  Pre-review passed.

Comment 4 Fernando Nasser 2009-05-18 01:38:59 UTC

New Package CVS Request
=======================
Package Name: plexus-containers
Short Description: Containers for Plexus
Owners: fnasser, dbhole
Branches: devel
InitialCC: jkeating

Comment 5 Kevin Fenzi 2009-05-18 04:24:43 UTC

cvs done.

Comment 6 Andrew Overholt 2009-08-20 15:29:11 UTC

Full review request:  bug #518489.

Comment 7 Andrew Overholt 2009-08-20 17:20:04 UTC

Built:  http://koji.fedoraproject.org/koji/taskinfo?taskID=1618018