Bug 502189
| Summary: | Review Request: libglpng - Toolkit for loading PNG images as OpenGL textures | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | Package Review | Assignee: | Nicolas Chauvet (kwizart) <kwizart> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kwizart, notting |
| Target Milestone: | --- | Flags: | kwizart:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-23 15:16:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 502191 | ||
|
Description
Hans de Goede
2009-05-22 13:22:55 UTC
- starting review - OK - package built with mock (tested on F-10 x86_64 & F-11 x86). OK - rpmlint libglpng on installed library is quiet. OK - library has a SONAME: 0x000000000000000e (SONAME) Library soname: [libglpng.so.1] Warning(OK) - Unused direct dependencies : # ldd -d -u /usr/lib64/libglpng.so.1.45 Unused direct dependencies: /usr/lib64/libpng12.so.0 /usr/lib64/libGL.so.1 This is weird since thoses are exactly the one that would be suggested to be usefull. One more reason not to trust too much unused direct dependencies. But at least, I don't understand why the Author speak about zlib ? It doesn't seems used from this library: quoting from glpng.htm: "It is implemented using modified versions of the LibPNG 1.0.2 and ZLib 1.1.3 libraries." Warning(OK) - directory owned by multiple package: /usr/include/GL: Since this libglpng-devel doesn't depend on another package that would own this directory, this is fine to own it. OK - source from package and website match: $ sha1sum libglpng_1.45.orig.tar.gz 98d9298c2a8588d4731af1ce22cfbf79ea5349cd libglpng_1.45.orig.tar.gz Warning(OK) - package doesn't bundle a License file, but header is explicit (MIT) Usability test: Tested with chromium (built time/ runtime) OK - (funny). This package is APPROVED (In reply to comment #2) > But at least, I don't understand why the Author speak about zlib ? It doesn't > seems used from this library: quoting from glpng.htm: > "It is implemented using modified versions of the LibPNG 1.0.2 and ZLib 1.1.3 > libraries." > I believe the original original tarbal (not the Debian one we're using since upstream is dead) indeed contained modified versions of libpng and zlib (see src/Makefile.LINUX). But the new Debian provided Makefile doesn't use those but uses the system versions instead. As for referencing zlib, well libpng uses zlib. > This package is APPROVED Thanks! New Package CVS Request ======================= Package Name: libglpng Short Description: Toolkit for loading PNG images as OpenGL textures Owners: jwrdegoede Branches: F-10 F-11 InitialCC: cvs done. Imported and build, closing. |