Spec URL: http://people.atrpms.net/~hdegoede/chromium-bsu.spec SRPM URL: http://people.atrpms.net/~hdegoede/chromium-bsu-0.9.14-1.fc11.src.rpm Description: You are captain of the cargo ship Chromium B.S.U., responsible for delivering supplies to our troops on the front line. Your ship has a small fleet of robotic fighters which you control from the relative safety of the Chromium vessel. This is an OpenGL-based shoot 'em up game with fine graphics. Note to reviewers: This needs ftgl 2.1.3 or newer which is only in the F-12 repo, you can download it here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1369999 It also needs libglpng, which still needs to be reviewed, its review is bug 502189.
We used to ship this a long time ago - why was it removed (and has whatever caused that been fixed)?
That was my first thought.
(In reply to comment #1) > We used to ship this a long time ago - why was it removed (and has whatever > caused that been fixed)? The issue was non free artwork and that has been fixed by upstream now (in collaboration with Debian, its completely dfsg free now)
Cool. I'll have a go.
rpmlint clean. URL should be http://chromium-bsu.sourceforge.net/ Rename README.license to chromium-README.license (but keep it README.license when installed) to avoid SRPM clobbering. Can't mock-test the BRs since ftgl isn't updated yet and libglpng isn't in rawhide yet, but I see that review's underway. Otherwise on full review, it looks great.
Thanks for the review! Here is an updated package with those 2 issues fixed: Spec URL: http://people.atrpms.net/~hdegoede/chromium-bsu.spec SRPM URL: http://people.atrpms.net/~hdegoede/chromium-bsu-0.9.14-2.fc11.src.rpm
Good deal, still waiting on libglpng to show up in my mock buildroot. . .
(In reply to comment #7) > Good deal, still waiting on libglpng to show up in my mock buildroot. . . Hmm, are you pointing mock at rawhide + F-11 updates ? rawhide == F-11 GA, so get the latest and greatest you need rawhide + F-11 updates.
[build@fawkes ~]$ cat /etc/mock/fedora-rawhide-i586.cfg config_opts['root'] = 'fedora-rawhide-i586' config_opts['target_arch'] = 'i586' config_opts['chroot_setup_cmd'] = 'groupinstall buildsys-build' config_opts['dist'] = 'fc12' # only useful for --resultdir variable subst config_opts['yum.conf'] = """ [main] cachedir=/var/cache/yum debuglevel=1 reposdir=/dev/null logfile=/var/log/yum.log retries=20 obsoletes=1 gpgcheck=0 assumeyes=1 # repos [fedora] name=fedora mirrorlist=http://mirrors.fedoraproject.org/mirrorlist?repo=rawhide&arch=i586 failovermethod=priority [local] name=local baseurl=http://koji.fedoraproject.org/static-repos/dist-rawhide-current/i386 cost=2000 enabled=0 """
Hmm, ok so no F-11 updates not F-11 updates-testing in there. Note that even if you did have that it still wont build as you also need the ftgl from F-12. So I guess its best to wait till rawhide unfreezes from F-11 and becomes F-12.
By the way mock build fails even for dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1379204
(In reply to comment #11) > By the way mock build fails even for dist-f12: > http://koji.fedoraproject.org/koji/taskinfo?taskID=1379204 Woops, my bad, here is a fixed version: Spec URL: http://people.atrpms.net/~hdegoede/chromium-bsu.spec SRPM URL: http://people.atrpms.net/~hdegoede/chromium-bsu-0.9.14-3.fc11.src.rpm And here is a working koji scratch build of it: http://koji.fedoraproject.org/koji/taskinfo?taskID=1379288
Looks good to me. APPROVED.
(In reply to comment #13) > Looks good to me. > > APPROVED. Thanks! New Package CVS Request ======================= Package Name: chromium-bsu Short Description: Fast paced, arcade-style, top-scrolling space shooter Owners: jwrdegoede Branches: F-11 InitialCC:
CVS done.
(In reply to comment #15) > CVS done. Thanks, imported and build, closing.