Bug 502189 - Review Request: libglpng - Toolkit for loading PNG images as OpenGL textures
Review Request: libglpng - Toolkit for loading PNG images as OpenGL textures
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nicolas Chauvet (kwizart)
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 502191
  Show dependency treegraph
 
Reported: 2009-05-22 09:22 EDT by Hans de Goede
Modified: 2009-05-23 11:16 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-05-23 11:16:52 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
kwizart: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Hans de Goede 2009-05-22 09:22:55 EDT
Spec URL: http://people.atrpms.net/~hdegoede/libglpng.spec
SRPM URL: http://people.atrpms.net/~hdegoede/libglpng-1.45-1.fc11.src.rpm
Description:
glpng is a small toolkit to make loading PNG image files as an OpenGL
texture as easy as possible.
Comment 1 Nicolas Chauvet (kwizart) 2009-05-22 11:24:04 EDT
- starting review -
Comment 2 Nicolas Chauvet (kwizart) 2009-05-22 12:14:52 EDT
OK - package built with mock (tested on F-10 x86_64 & F-11 x86).
OK - rpmlint libglpng on installed library is quiet.
OK - library has a SONAME:
 0x000000000000000e (SONAME)             Library soname: [libglpng.so.1]
Warning(OK) - Unused direct dependencies :
# ldd -d -u /usr/lib64/libglpng.so.1.45
Unused direct dependencies:
	
	/usr/lib64/libpng12.so.0
	/usr/lib64/libGL.so.1
This is weird since thoses are exactly the one that would be suggested to be usefull. One more reason not to trust too much unused direct dependencies.
But at least, I don't understand why the Author speak about zlib ? It doesn't seems used from this library: quoting from glpng.htm:
"It is implemented using modified versions of the LibPNG 1.0.2 and ZLib 1.1.3 libraries."

Warning(OK) - directory owned by multiple package: /usr/include/GL:
  Since this libglpng-devel doesn't depend on another package that would own this directory, this is fine to own it.

OK - source from package and website match:
$ sha1sum libglpng_1.45.orig.tar.gz 
98d9298c2a8588d4731af1ce22cfbf79ea5349cd  libglpng_1.45.orig.tar.gz

Warning(OK) - package doesn't bundle a License file, but header is explicit (MIT)

Usability test:
Tested with chromium (built time/ runtime)
OK - (funny).

This package is APPROVED
Comment 3 Hans de Goede 2009-05-22 14:26:27 EDT
(In reply to comment #2)
> But at least, I don't understand why the Author speak about zlib ? It doesn't
> seems used from this library: quoting from glpng.htm:
> "It is implemented using modified versions of the LibPNG 1.0.2 and ZLib 1.1.3
> libraries."
> 

I believe the original original tarbal (not the Debian one we're using
since upstream is dead) indeed contained modified versions of libpng
and zlib (see src/Makefile.LINUX). But the new Debian provided Makefile
doesn't use those but uses the system versions instead. As for referencing
zlib, well libpng uses zlib.

> This package is APPROVED  

Thanks!
Comment 4 Hans de Goede 2009-05-22 14:27:56 EDT
New Package CVS Request
=======================
Package Name:      libglpng
Short Description: Toolkit for loading PNG images as OpenGL textures
Owners:            jwrdegoede
Branches:          F-10 F-11
InitialCC:
Comment 5 Kevin Fenzi 2009-05-23 01:43:19 EDT
cvs done.
Comment 6 Hans de Goede 2009-05-23 11:16:52 EDT
Imported and build, closing.

Note You need to log in before you can comment on or make changes to this bug.