Red Hat Bugzilla – Bug 502189
Review Request: libglpng - Toolkit for loading PNG images as OpenGL textures
Last modified: 2009-05-23 11:16:52 EDT
Spec URL: http://people.atrpms.net/~hdegoede/libglpng.spec
SRPM URL: http://people.atrpms.net/~hdegoede/libglpng-1.45-1.fc11.src.rpm
glpng is a small toolkit to make loading PNG image files as an OpenGL
texture as easy as possible.
- starting review -
OK - package built with mock (tested on F-10 x86_64 & F-11 x86).
OK - rpmlint libglpng on installed library is quiet.
OK - library has a SONAME:
0x000000000000000e (SONAME) Library soname: [libglpng.so.1]
Warning(OK) - Unused direct dependencies :
# ldd -d -u /usr/lib64/libglpng.so.1.45
Unused direct dependencies:
This is weird since thoses are exactly the one that would be suggested to be usefull. One more reason not to trust too much unused direct dependencies.
But at least, I don't understand why the Author speak about zlib ? It doesn't seems used from this library: quoting from glpng.htm:
"It is implemented using modified versions of the LibPNG 1.0.2 and ZLib 1.1.3 libraries."
Warning(OK) - directory owned by multiple package: /usr/include/GL:
Since this libglpng-devel doesn't depend on another package that would own this directory, this is fine to own it.
OK - source from package and website match:
$ sha1sum libglpng_1.45.orig.tar.gz
Warning(OK) - package doesn't bundle a License file, but header is explicit (MIT)
Tested with chromium (built time/ runtime)
OK - (funny).
This package is APPROVED
(In reply to comment #2)
> But at least, I don't understand why the Author speak about zlib ? It doesn't
> seems used from this library: quoting from glpng.htm:
> "It is implemented using modified versions of the LibPNG 1.0.2 and ZLib 1.1.3
I believe the original original tarbal (not the Debian one we're using
since upstream is dead) indeed contained modified versions of libpng
and zlib (see src/Makefile.LINUX). But the new Debian provided Makefile
doesn't use those but uses the system versions instead. As for referencing
zlib, well libpng uses zlib.
> This package is APPROVED
New Package CVS Request
Package Name: libglpng
Short Description: Toolkit for loading PNG images as OpenGL textures
Branches: F-10 F-11
Imported and build, closing.