Bug 504471
| Summary: | Review Request: rubygem-sinatra - Ruby-based web application framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Michal Ingeli <mi> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, mi, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.10.1-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-19 19:43:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 504472, 504474 | ||
| Bug Blocks: | |||
|
Description
Lubomir Rintel
2009-06-07 11:44:33 UTC
Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-sinatra.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-sinatra-0.9.2-2.fc11.src.rpm SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-sinatra.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-sinatra-0.9.2-3.fc11.src.rpm *** Bug 553185 has been marked as a duplicate of this bug. *** SPEC: http://mifo.sk/rubygem-sinatra.spec SRPM: http://mifo.sk/rubygem-sinatra-0.10.1-4.fc12.src.rpm Michal, please mark the japan documentation asi %lang(jp). And no useless comments please:
#%{geminstdir}/compat
For the sake of review, I otherwise agree with Michal's changes. Fixed. Thank you Lubomir. Fixed rev number in SRPM: SPEC: http://mifo.sk/rubygem-sinatra.spec SRPM: http://mifo.sk/rubygem-sinatra-0.10.1-1.fc12.src.rpm Review: # MUST: rpmlint must be run on every package. The output should be posted in the review. 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # MUST: The package must be named according to the Package Naming Guidelines . OK # MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK # MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . MIT # MUST: The spec file must be written in American English. OK # MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. http://gems.rubyforge.org/gems # MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. OK # MUST: Header files must be in a -devel package. No headers. # MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK # MUST: All filenames in rpm packages must be valid UTF-8. OK New Package CVS Request ======================= Package Name: rubygem-sinatra Short Description: Ruby-based web application framework Owners: lkundrak mfojtik Branches: F-11 F-12 EL-5 CVS done. rubygem-sinatra-0.10.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-sinatra-0.10.1-1.fc12 rubygem-sinatra-0.10.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |