Bug 504749
| Summary: | Review Request: perl-Catalyst-View-PDF-Reuse - Create PDF files from Catalyst using Template Toolkit templates | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Catalyst-View-PDF-Reuse | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-22 05:08:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 504748 | ||
| Bug Blocks: | |||
|
Description
Chris Weyl
2009-06-09 07:45:41 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-View-PDF-Reuse.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-View-PDF-Reuse-0.03-2.fc11.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1410391 Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1410391 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 382662ecadff11707e78053f75ea395cc37a4e79 Catalyst-View-PDF-Reuse-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=7, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.61 cusr 0.05 csys = 1.71 CPU) + Package perl-Catalyst-View-PDF-Reuse-0.03-2.fc12.noarch => Provides: perl(Catalyst::Helper::View::PDF::Reuse) perl(Catalyst::View::PDF::Reuse) = 0.03 perl(Template::Plugin::Catalyst::View::PDF::Reuse) Requires: perl(File::Spec::Functions) perl(File::Temp) perl(File::chdir) perl(PDF::Reuse) perl(base) perl(parent) perl(strict) perl(warnings) + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-View-PDF-Reuse Short Description: Create PDF files from Catalyst using Template Toolkit templates Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig CVS done. Thanks for the review! :-) |