Spec URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-View-PDF-Reuse.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-View-PDF-Reuse-0.03-1.fc10.src.rpm Description: Catalyst::View::PDF::Reuse provides the facility to generate PDF files from a Catalyst application by embedding PDF::Reuse commands within a Template::Toolkit template. Within your template you will have access to a 'pdf' object which has methods corresponding to all of PDF::Reuse's functions. *rt-0.10
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-View-PDF-Reuse.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Catalyst-View-PDF-Reuse-0.03-2.fc11.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1410391
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1410391 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 382662ecadff11707e78053f75ea395cc37a4e79 Catalyst-View-PDF-Reuse-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=7, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.61 cusr 0.05 csys = 1.71 CPU) + Package perl-Catalyst-View-PDF-Reuse-0.03-2.fc12.noarch => Provides: perl(Catalyst::Helper::View::PDF::Reuse) perl(Catalyst::View::PDF::Reuse) = 0.03 perl(Template::Plugin::Catalyst::View::PDF::Reuse) Requires: perl(File::Spec::Functions) perl(File::Temp) perl(File::chdir) perl(PDF::Reuse) perl(base) perl(parent) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Catalyst-View-PDF-Reuse Short Description: Create PDF files from Catalyst using Template Toolkit templates Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
CVS done.
Thanks for the review! :-)