Bug 506536
Summary: | Add a MIME type definition so we can associate congruity with the appropriate files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
Component: | libconcord | Assignee: | Douglas E. Warner <silfreed> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | anssi.hannula, silfreed |
Target Milestone: | --- | Keywords: | Patch, Upstream |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.21-4.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-08-28 21:58:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 514983 | ||
Bug Blocks: | |||
Attachments: |
Description
Adam Williamson
2009-06-17 16:54:55 UTC
Created attachment 348295 [details]
MIME type definition for libconcord
Created attachment 348296 [details]
MIME type definition for libconcord
actually, it should be called %{_datadir}/mime/packages/libconcord.xml , sorry. not congruity. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Here's a better way...I patched it into the upstream source. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Created attachment 348306 [details]
Patch for upstream libconcord to install a MIME type definition file
Created attachment 348307 [details]
Patch for libconcord.spec to apply the MIME patch to the upstream code
Reported upstream: http://sourceforge.net/tracker/?func=detail&aid=2807865&group_id=201579&atid=978130 Thanks for the patches; I'll get them integrated into our builds for all releases shortly; a rawhide package should be coming through soon. The build is trying to run autoreconf, so I have to get that fixed up before it's ready to go. Current patch is in CVS. I prefer to do things that way (just patch the source files and re-run autoreconf, rather than patching the generated files); which is the 'best' way appears to be something of a bone of contention, going on past f-d-l threads :) but it's your package, I don't mind which way you go, and it'll get upstreamed anyway I expect, since upstream is active. thanks again. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Right; your patch will probably be the one I send upstream. I'm just trying to get it updated for CVS so I don't need to run autoreconf inside the build of the package. The Logitech server already sends mimetypes for the files: application/x-easyzapper-hex application/x-easyzapper-upgrade application/x-easyzapper-tutor Mandriva's .desktop file for congruity has those types associated with it, so it works out-of-the-box (with firefox at least; apparently kde4 konqueror has some problems with it) without any new mime type definitions. Adding the mimetype files anyway is probably not a bad idea, but maybe we should use the same mimetype definitions the server reports? It is possible some browsers trust server for mimetype info, thus not associating the files with congruity. Nicely spotted, Anssi - I hadn't noticed that. I'd support your suggestion; Douglas, can you revise my patch a bit to use the upstream MIME types, as Anssi suggests? Thanks! -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers I put my modified patch in the upstream bugreport. I dropped the <magic> entry from it, though, as I didn't see what it was for, and asked you for comment :) is this going to go through? I already sent congruity out into the distro, it'd be nice to have this fix in libconcord so it works 'out of the box'. thanks! -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Yeah, I'm actually looking at it right now due to the f12 failed rebuild. great, thanks. please use anssi's better version of the patch, rather than mine :) -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers libconcord-0.21-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libconcord-0.21-3.fc10 libconcord-0.21-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libconcord-0.21-3.fc11 That's still using my patch. As I said, Anssi's is better than mine, as it drops the spurious <magic> section, and uses the same MIME type the Logitech server sends out. Could you switch to that patch? Thanks! http://stuff.onse.fi/concordance-mime2.patch -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Sure; thanks for the link. I just picked the one that was attached to the upstream bug and didn't realize it was still yours. I'll try to put that together tomorrow. thanks, sorry for the trouble. I think Anssi missed the way to attach things to reports in the sourceforge tracker. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers libconcord-0.21-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libconcord'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8167 CVS has been updated with a new patch and has been tagged, but I can't build right now due to a broken swig package [1]. I'll be leaving on vacation this week but will try to monitor the situation. If anyone sees its fixed and wants to build it before I do, feel free -- I'll try to push it to updates as soon as I see it's built. [1] https://www.redhat.com/archives/fedora-devel-list/2009-July/msg02068.html Actually, it looks like the F11 package built fine so you could test from koji if you liked. Thanks for the change. I've submitted a patch to congruity to change to the new MIME types, I'll bring that downstream into the Fedora package once it's accepted. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers can you poke me when this hits updates for f10 and f11? i've pushed the new congruity release to rawhide, but I don't want to push it to f10 and f11 till the libconcord switch is done. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers libconcord-0.21-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libconcord-0.21-4.fc11 libconcord-0.21-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libconcord-0.21-4.fc10 libconcord-0.21-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libconcord'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8463 libconcord-0.21-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libconcord'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8489 libconcord-0.21-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. libconcord-0.21-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |