Bug 506712
| Summary: | Package Review: libccss - A simple api for CSS Stylesheets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | bnocera, fedora-package-review, notting, pbrobinson, yaneti |
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-24 20:34:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 506446, 506721 | ||
|
Description
Peter Robinson
2009-06-18 13:04:23 UTC
This time I looked through the source files and they all have the "or (at your option) any later version" variety, which in my understanding makes the package LGPLv2+ . URL: http://cgit.freedesktop.org/ccss/ or URL: http://people.freedesktop.org/~robsta/libccss/ BuildRequires: gtk-doc is not really necessary, the tarball has the docs already built. The last paragraph of the description seems out of place (everything after the bullet points) . Perhaps just remove it. You could add --disable-examples to spare few cycles. There is a TODO file that looks to be maintained. You could %{_includedir}/libccss-1 and be done with it. If the package is not split on cairo/gtk etc. there is hardly a point in listing everything. Other than the license, all minor concerns. I believe you'll fix that prior to import. APPROVED. Again as with rest some head scratching on weather it should be called libccss or ccss , but I like the idea of sticking with the tarball name best. And its just a library. > This time I looked through the source files and they all have the "or (at your > option) any later version" variety, which in my understanding makes the package > LGPLv2+ . Updated in my local ver > URL: http://cgit.freedesktop.org/ccss/ > or > URL: http://people.freedesktop.org/~robsta/libccss/ Have used the later for the moment. It seems from comments that it will eventually be all on freedesktop.org so will update it as it channges > BuildRequires: gtk-doc > is not really necessary, the tarball has the docs already built. > > The last paragraph of the description seems out of place (everything after the > bullet points) . Perhaps just remove it. > > You could add --disable-examples to spare few cycles. > > There is a TODO file that looks to be maintained. Done > You could > %{_includedir}/libccss-1 > and be done with it. If the package is not split on cairo/gtk etc. there is > hardly a point in listing everything. I've done it that way mainly so I see if there's any changes by a broken build :-) > Other than the license, all minor concerns. I believe you'll fix that prior to > import. APPROVED. Thanks! > Again as with rest some head scratching on weather it should be called libccss > or ccss , but I like the idea of sticking with the tarball name best. And its > just a library. So did I but I figured that as the tarball was libccss I would use that to follow conventions. New Package CVS Request ======================= Package Name: libccss Short Description: A simple api for CSS Stylesheets Owners: pbrobinson Branches: F-11 F-10 InitialCC: CVS done. built in rawhide You did commit with URL: http://www.gnome.org/~ebassi/source/ which isn't for this particular lib... Sorry, lost in the 100s of spec changes I was dealing with yesterday. Its now committed to cvs so I won't miss it. It will appear the next time I push the package. -URL: http://www.gnome.org/~ebassi/source/ +URL: http://live.gnome.org/TwitterGlib Sorry, but for libccss this isn't the one either ;) I guess you meant http://people.freedesktop.org/~robsta/libccss/ Correct :) and fixed. Thanks! Done. Thanks for the review! |