Bug 508416

Summary:	Review Request: rubygem-mkrf - Making C extensions for Ruby a bit easier
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lkundrak, notting, ulrich.schwickerath
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	lkundrak: fedora-review+ gwync: fedora-cvs+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-02 15:13:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	508417

Description Mamoru TASAKA 2009-06-26 22:46:44 UTC

Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf-0.2.3-1.fc.src.rpm
Description: 
mkrf is a library for generating Rakefiles to build Ruby
extension modules written in C. It is intended as a replacement for
mkmf. The major difference between the two is that mkrf
builds you a Rakefile instead of a Makefile.

koji scratch build:
For F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1437438
For F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1437830

There are many rpmlint warining/errors on -doc subpackage, however
these are on examples and I think they are safe to ignore.

Comment 1 Lubomir Rintel 2009-07-08 17:27:05 UTC

(In reply to comment #0)
> There are many rpmlint warining/errors on -doc subpackage, however
> these are on examples and I think they are safe to ignore.  

Agreed.

* Package named correctly
* Macros used consistently
* Builds fine in mock
* Requires/provides sane
* filelist mostly sane (see below)
* rpmlint mostly ok (see below)
* spec file clean and legible
  (well, you could improve indentation in %globals paragraph :)

Needs work:

1.) Tests failing. According to the comments you seem to be aware of that. Not blocking a review.

2.) Rpmlint

rubygem-mkrf.noarch: E: non-readable /usr/lib/ruby/gems/1.8/cache/mkrf-0.2.3.gem 0600

You probably want to change this via %attr in %files or change the mode in %install or something.

Comment 2 Mamoru TASAKA 2009-07-08 18:13:22 UTC

Thank you for review.

(In reply to comment #1)
> * spec file clean and legible
>   (well, you could improve indentation in %globals paragraph :)
- Perhaps now it should look better.

> 2.) Rpmlint
> 
> rubygem-mkrf.noarch: E: non-readable
> /usr/lib/ruby/gems/1.8/cache/mkrf-0.2.3.gem 0600
> 
> You probably want to change this via %attr in %files or change the mode in
> %install or something.  
- Fixed.

http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf-0.2.3-2.fc.src.rpm

* Thu Jul  9 2009 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.2.3-2
- Improve indentation
- Make sure gem is installed with proper permission

Comment 3 Lubomir Rintel 2009-07-08 18:26:05 UTC

Looks fine now, thanks.

APPROVED

Comment 4 Mamoru TASAKA 2009-07-08 18:36:10 UTC

Thank you!

New Package CVS Request 
=======================
Package Name:       rubygem-mkrf
Short Description:  Making C extensions for Ruby a bit easier
Owners:             mtasaka
Branches:           F-11 F-10
InitialCC:          (nobody)

Comment 5 Jason Tibbitts 2009-07-10 03:35:04 UTC

CVS done.

Comment 6 Mamoru TASAKA 2009-07-15 17:36:20 UTC

Now closing. Thank you for reviewing and CVS procedure.

Comment 7 Ulrich Schwickerath 2012-03-20 12:58:51 UTC

Hi,

would it be possible to have this package for el6 as well ? It is required by rubygem-xmlparser

Thanks a lot!
Ulrich

Comment 8 Mamoru TASAKA 2012-03-20 13:24:24 UTC

(In reply to comment #7)
> would it be possible to have this package for el6 as well ? I

Currently I don't have any intention of maintaining packages on EPEL. If you want this package on EPEL, please feel free to become the maintainer on EPEL.

Comment 9 Ulrich Schwickerath 2012-04-24 15:34:35 UTC

Package Change Request
======================
Package Name: rubygem-mkrf
New Branches: el6
Owners: schwicke

Comment 10 Gwyn Ciesla 2012-04-24 16:41:34 UTC

Git done (by process-git-requests).

Comment 11 Mamoru TASAKA 2013-01-02 15:13:33 UTC

Closing this as this need not being open.