Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-ruby-oepngl/rubygem-ruby-opengl.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-ruby-oepngl/rubygem-ruby-opengl-0.60.1-2.fc.src.rpm Description: ruby-opengl consists of Ruby extension modules that are bindings for the OpenGL, GLU, and GLUT libraries. It is intended to be a replacement for -- and uses the code from -- Yoshi's ruby-opengl. Koji sratch build: - Not available yet because this depends on bug 508416 - However mock build results for dist-f12 i586/x86_64 are available on: http://mtasaka.fedorapeople.org/Review_request/rubygem-ruby-oepngl/Results/
By the way the naming seems a bit strange, however gem name is actually called as "ruby-opengl" so I think "rubygem-ruby-opengl" is proper for srpm name.
(In reply to comment #1) > By the way the naming seems a bit strange, however gem name is > actually called as "ruby-opengl" so I think "rubygem-ruby-opengl" is > proper for srpm name. Definitely. * Named correctly * SPEC file clean, legible and in american english * license correct * builds fine in mock * Proper compiler flags used * filelists sane * require/provide list seems sane Tip: You may want to fill in the %check section with the testsuite executed conditionally (e.g. prepend it with [ "$DISPLAY" ] || exit 0), so that the maintainer (you) can run the tests in his development setup before sumbitting the package into the build system. APPROVED (please don't import/build before the minor concerns from the dependency package are addressed and it is approved as well)
Thank you! Now as bug 508416 is approved: -------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-ruby-opengl Short Description: OpenGL Interface for Ruby Owners: mtasaka Branches: F-11 F-10 InitialCC: (nobody)
CVS done.
Now closing. Thank you for reviewing and CVS procedure.