Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf-0.2.3-1.fc.src.rpm Description: mkrf is a library for generating Rakefiles to build Ruby extension modules written in C. It is intended as a replacement for mkmf. The major difference between the two is that mkrf builds you a Rakefile instead of a Makefile. koji scratch build: For F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1437438 For F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1437830 There are many rpmlint warining/errors on -doc subpackage, however these are on examples and I think they are safe to ignore.
(In reply to comment #0) > There are many rpmlint warining/errors on -doc subpackage, however > these are on examples and I think they are safe to ignore. Agreed. * Package named correctly * Macros used consistently * Builds fine in mock * Requires/provides sane * filelist mostly sane (see below) * rpmlint mostly ok (see below) * spec file clean and legible (well, you could improve indentation in %globals paragraph :) Needs work: 1.) Tests failing. According to the comments you seem to be aware of that. Not blocking a review. 2.) Rpmlint rubygem-mkrf.noarch: E: non-readable /usr/lib/ruby/gems/1.8/cache/mkrf-0.2.3.gem 0600 You probably want to change this via %attr in %files or change the mode in %install or something.
Thank you for review. (In reply to comment #1) > * spec file clean and legible > (well, you could improve indentation in %globals paragraph :) - Perhaps now it should look better. > 2.) Rpmlint > > rubygem-mkrf.noarch: E: non-readable > /usr/lib/ruby/gems/1.8/cache/mkrf-0.2.3.gem 0600 > > You probably want to change this via %attr in %files or change the mode in > %install or something. - Fixed. http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf-0.2.3-2.fc.src.rpm * Thu Jul 9 2009 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.2.3-2 - Improve indentation - Make sure gem is installed with proper permission
Looks fine now, thanks. APPROVED
Thank you! New Package CVS Request ======================= Package Name: rubygem-mkrf Short Description: Making C extensions for Ruby a bit easier Owners: mtasaka Branches: F-11 F-10 InitialCC: (nobody)
CVS done.
Now closing. Thank you for reviewing and CVS procedure.
Hi, would it be possible to have this package for el6 as well ? It is required by rubygem-xmlparser Thanks a lot! Ulrich
(In reply to comment #7) > would it be possible to have this package for el6 as well ? I Currently I don't have any intention of maintaining packages on EPEL. If you want this package on EPEL, please feel free to become the maintainer on EPEL.
Package Change Request ====================== Package Name: rubygem-mkrf New Branches: el6 Owners: schwicke
Git done (by process-git-requests).
Closing this as this need not being open.