Bug 508417

Summary:	Review Request: rubygem-ruby-opengl - OpenGL Interface for Ruby
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lkundrak, notting
Target Milestone:	---	Flags:	lkundrak: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-07-15 17:38:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	508416
Bug Blocks:

Description Mamoru TASAKA 2009-06-26 22:48:38 UTC

Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-ruby-oepngl/rubygem-ruby-opengl.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-ruby-oepngl/rubygem-ruby-opengl-0.60.1-2.fc.src.rpm
Description:
ruby-opengl consists of Ruby extension modules that are bindings 
for the OpenGL, GLU, and GLUT libraries. It is intended to be 
a replacement for -- and uses the code from -- Yoshi's ruby-opengl.

Koji sratch build:
- Not available yet because this depends on bug 508416
- However mock build results for dist-f12 i586/x86_64 are available on:
  http://mtasaka.fedorapeople.org/Review_request/rubygem-ruby-oepngl/Results/

Comment 1 Mamoru TASAKA 2009-06-26 22:50:43 UTC

By the way the naming seems a bit strange, however gem name is
actually called as "ruby-opengl" so I think "rubygem-ruby-opengl" is
proper for srpm name.

Comment 2 Lubomir Rintel 2009-07-08 17:33:50 UTC

(In reply to comment #1)
> By the way the naming seems a bit strange, however gem name is
> actually called as "ruby-opengl" so I think "rubygem-ruby-opengl" is
> proper for srpm name.  

Definitely.

* Named correctly
* SPEC file clean, legible and in american english
* license correct
* builds fine in mock
* Proper compiler flags used
* filelists sane
* require/provide list seems sane

Tip: You may want to fill in the %check section with the testsuite executed conditionally (e.g. prepend it with [ "$DISPLAY" ] || exit 0), so that the maintainer (you) can run the tests in his development setup before sumbitting the package into the build system.

APPROVED

(please don't import/build before the minor concerns from the dependency package are addressed and it is approved as well)

Comment 3 Mamoru TASAKA 2009-07-08 18:44:41 UTC

Thank you!

Now as bug 508416 is approved:
--------------------------------------------------------
New Package CVS Request 
=======================
Package Name:       rubygem-ruby-opengl
Short Description:  OpenGL Interface for Ruby
Owners:             mtasaka
Branches:           F-11 F-10
InitialCC:          (nobody)

Comment 4 Jason Tibbitts 2009-07-10 03:35:38 UTC

CVS done.

Comment 5 Mamoru TASAKA 2009-07-15 17:38:09 UTC

Now closing. Thank you for reviewing and CVS procedure.