Bug 508453

Summary:	Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit
Product:	[Fedora] Fedora	Reporter:	Lubomir Rintel <lkundrak>
Component:	Package Review	Assignee:	Michal Ingeli <mi>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, mastahnke, mi, notting
Target Milestone:	---	Flags:	mi: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-07-31 06:11:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Rintel 2009-06-27 11:38:34 UTC

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec
SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-1.fc11.src.rpm

Description:

Test/spec layers an RSpec-inspired interface on top of Test::Unit, so you
can mix TDD and BDD (Behavior-Driven Development).  It is a clean-room
implementation that maps most kinds of Test::Unit assertions to a
should-like syntax.

Comment 1 Michal Ingeli 2009-06-28 12:52:47 UTC

* naming ok
* spec file clean, american english
* file lists ok, examples in documentation
* builds in mock
* rpmlint silent
* source matches upstream

work to do:
- package is distributed in the same terms as ruby is. So it should have ruby license or GPLv2. Not GPLv2+.
- Consistent build root reference. In %clean stare it's referred to build root as %{buildroot} and other stages uses $RPM_BUILD_ROOT.
- add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)

Comment 2 Lubomir Rintel 2009-07-08 17:01:09 UTC

(In reply to comment #1)

> work to do:
> - package is distributed in the same terms as ruby is. So it should have ruby
> license or GPLv2. Not GPLv2+.

Good catch. Fixed.

> - Consistent build root reference. In %clean stare it's referred to build root
> as %{buildroot} and other stages uses $RPM_BUILD_ROOT.

Fixed.

> - add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)

bug #510313

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-2.fc11.src.rpm

Comment 3 Michal Ingeli 2009-07-13 11:54:43 UTC

All work done, looks good.

APPROVED

Comment 4 Lubomir Rintel 2009-07-13 12:24:08 UTC

New Package CVS Request
=======================
Package Name: rubygem-test-spec
Short Description: Behaviour Driven Development interface for Test::Unit
Owners: lkundrak
Branches: F-11 EL-5

Comment 5 Kevin Fenzi 2009-07-14 04:48:52 UTC

cvs done.

Comment 6 Lubomir Rintel 2009-07-31 06:11:51 UTC

Thanks for the review and CVS. Imported and build.

Comment 7 Michael Stahnke 2010-04-16 22:15:24 UTC

Is there a reason this was built for EPEL5 but never put in as an update?  If you would like a co-maintainer in EPEL, I'd be happy to do it.