Fedora Account System
Red Hat Associate
Red Hat Customer
SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-1.fc11.src.rpm Description: Test/spec layers an RSpec-inspired interface on top of Test::Unit, so you can mix TDD and BDD (Behavior-Driven Development). It is a clean-room implementation that maps most kinds of Test::Unit assertions to a should-like syntax.
* naming ok * spec file clean, american english * file lists ok, examples in documentation * builds in mock * rpmlint silent * source matches upstream work to do: - package is distributed in the same terms as ruby is. So it should have ruby license or GPLv2. Not GPLv2+. - Consistent build root reference. In %clean stare it's referred to build root as %{buildroot} and other stages uses $RPM_BUILD_ROOT. - add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)
(In reply to comment #1) > work to do: > - package is distributed in the same terms as ruby is. So it should have ruby > license or GPLv2. Not GPLv2+. Good catch. Fixed. > - Consistent build root reference. In %clean stare it's referred to build root > as %{buildroot} and other stages uses $RPM_BUILD_ROOT. Fixed. > - add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint) bug #510313 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-2.fc11.src.rpm
All work done, looks good. APPROVED
New Package CVS Request ======================= Package Name: rubygem-test-spec Short Description: Behaviour Driven Development interface for Test::Unit Owners: lkundrak Branches: F-11 EL-5
cvs done.
Thanks for the review and CVS. Imported and build.
Is there a reason this was built for EPEL5 but never put in as an update? If you would like a co-maintainer in EPEL, I'd be happy to do it.