Bug 509485

Summary: commit_first_segment feature doesn't work
Product: [Fedora] Fedora Reporter: Akira TAGOH <tagoh>
Component: ibus-anthyAssignee: fujiwara <tfujiwar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: i18n-bugs, petersen, phuang, tagoh, tfujiwar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.1.0.20090814-1.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-28 22:01:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for engine/engine.py
none
Patch for engine/engine.py none

Description Akira TAGOH 2009-07-03 02:59:51 UTC 
Description of problem:
As per ibus-anthy config UI, commit_first_segment shortcut key are assigned to Shift+Down though, even if pressing Shift+Down during conversion, nothing happens.

Version-Release number of selected component (if applicable):
ibus-1.1.0.20090612-1.fc11
ibus-anthy-1.1.0.20090603-1.fc11

How reproducible:
always

Steps to Reproduce:
1.turn on IM
2.type nihongonobenkyou and press space
3.press shift+down
  
Actual results:
nothing happens. the candidate word at the first segment still is in the preedit

Expected results:
should be committed.

Additional info:
Comment 1 Jens Petersen 2009-07-28 09:31:09 UTC 
also true for ibus-anthy-1.2.0.20090617-1.fc12
Comment 2 fujiwara 2009-08-11 05:58:07 UTC 
I could reproduce this bug on trunk.
Comment 3 fujiwara 2009-08-11 06:11:53 UTC 
Created attachment 356978 [details]
Patch for engine/engine.py

Implemented commit_first_segment function.

1. Commit the first segment.
2. Remove the first segment in preedit.
3. Remove the segment element.
4. Update lookup string.

There are several regression tests.

test case 1:
2 segments
space, shift + down arrow, space, enter

test case 2:
2 segment
space, shift + down arrow, backspace, space, enter

test case 3:
2 segment
space, shift + down arrow, shift + down arrow

test case 4:
3 segment
space, shift + down, shift + down, shift + down

test case 5:
3 segment
space, shift + down, space, enter

test case 6:
3 segment
space, shift + down, shift + down, space, enter

test case 7:
3 segment
right arrow, space, shift + down, shift + down, shift + down

test case 8:
3 segment
right arrow, right arrow, space, shift + down, shift + down, shift + down
Comment 4 fujiwara 2009-08-12 05:35:12 UTC 
*** Bug 509486 has been marked as a duplicate of this bug. ***
Comment 5 fujiwara 2009-08-12 05:37:57 UTC 
Created attachment 357115 [details]
Patch for engine/engine.py

Updated the patch for bug 509486.
Comment 6 fujiwara 2009-08-13 09:17:03 UTC 
It seems now is alpha freeze but the build is finised.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1602834
Comment 7 fujiwara 2009-08-14 05:34:52 UTC 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1604603
Comment 8 Fedora Update System 2009-08-14 06:01:59 UTC 
ibus-anthy-1.1.0.20090814-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/ibus-anthy-1.1.0.20090814-1.fc11
Comment 9 Fedora Update System 2009-08-15 08:23:51 UTC 
ibus-anthy-1.1.0.20090814-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ibus-anthy'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8610
Comment 10 Fedora Update System 2009-08-28 22:00:52 UTC 
ibus-anthy-1.1.0.20090814-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.