Bug 516534
| Summary: | Review Request: globus-gram-job-manager-callout-error - Globus Toolkit - Globus GRAM Jobmanager Callout Errors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, steve.traylen |
| Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.2-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-04 12:37:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 516536 | ||
|
Description
Mattias Ellert
2009-08-10 11:03:27 UTC
Comment: The end result of this huge number of packages is excellent but the work the process to get to that point..... It's worth while for sure. Liked the article. http://www.isgtw.org/?pid=1002049 Review of globus-gram-job-manager-callout-error Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1750703 NO: rpmlint $ rpmlint globus-gram-job-manager-callout-error.spec ../SRPMS/globus-gram-job-manager-callout-error-0.2-1.fc11.src.rpm ../RPMS/x86_64/globus-gram-job-manager-callout-error-* ../RPMS/noarch/globus-gram-job-manager-callout-error-doc-0.2-1.fc11.noarch.rpm globus-gram-job-manager-callout-error-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package globus-gram-job-manager-callout-error. globus-gram-job-manager-callout-error-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 1 errors, 1 warnings. Just the trivial line to long but its easy to fix, presumably can be added to your .spec generator. YES: pkg name good. YES: spec file name good. YES: Meets globus guidelines. YES: License YES: License in .spec file. YES: Licesne files in package YES: American English. YES: Spec legible. YES: $ diff -r --brief globus_gram_job_manager_callout_error-0.2 ~/globus/src/gt4.2.1-all-source-installer/source-trees/gram/jobmanager/callout_error/ Only in globus_gram_job_manager_callout_error-0.2: GLOBUS_LICENSE which is expected. YES: Builds fine, see koji above. YES: Builds on all YES: BR good, in koji. YES: No locales present. YES: ldconfig called suitably. YES: No system libs. YES: Not relocatable. YES: Owns directories or pulls them in. YES: No double enties. YES: All defattr. YES: build root removed on clean. YES: Consistant use of macros. YES: Yes there is code if not a lot. YES: %doc not needed runtime. YES: devel package good. YES: devel requires libs. $ rpm -pq --requires globus-gram-job-manager-callout-error-devel-0.2-1.fc11.x86_64.rpm /usr/bin/pkg-config globus-common-devel(x86-64) >= 3 globus-core(x86-64) >= 4 globus-gram-job-manager-callout-error(x86-64) = 0.2-1.fc11 YES: no .la files present. YES: no gui. YES: utf8 Just the trivial description. Steve (In reply to comment #1) > Comment: > The end result of this huge number of packages is excellent but the > work the process to get to that point..... It's worth while for > sure. Liked the article. > http://www.isgtw.org/?pid=1002049 Thanks. > Just the trivial line to long but its easy to fix, presumably can > be added to your .spec generator. > > Just the trivial description. The discussion in bug 516516, comment 2 applies here as well. Quoting the above reference: "The definition of the description of the debuginfo package is not part if the specfile, but is defined in the %debug_info macro." Comment #2 satisfies everything. APPROVED Steve Many thanks for the review! New Package CVS Request ======================= Package Name: globus-gram-job-manager-callout-error Short Description: Globus Toolkit - Globus GRAM Jobmanager Callout Errors Owners: ellert Branches: F-11 F-12 EL-4 EL-5 InitialCC: cvs done. globus-gram-job-manager-callout-error-0.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-gram-job-manager-callout-error-0.2-1.fc11 globus-gram-job-manager-callout-error-0.2-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/globus-gram-job-manager-callout-error-0.2-1.el5 globus-gram-job-manager-callout-error-0.2-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/globus-gram-job-manager-callout-error-0.2-1.el4 globus-gram-job-manager-callout-error-0.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. globus-gram-job-manager-callout-error-0.2-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. globus-gram-job-manager-callout-error-0.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |